-
Notifications
You must be signed in to change notification settings - Fork 473
Code Review
JasonGlazer edited this page Nov 23, 2015
·
4 revisions
- Review the CI test reports
- Run the defect files first with the latest release (or current develop) to confirm the original failure.
- pull down the code and do a debug build and run the defect files to make sure everything runs ok.
- build EnergyPlusTests and run it as a full set (no filter).
- review the code and unit test and comment as needed.
- Merge
- Delete the branch
- Make sure the issue(s) addressed is closed (might close automatically if referenced in a commit). If not closed, then close with a comment like "Close via PRnnnn"
- Accept on Pivotal