Skip to content

Commit 775b332

Browse files
An PhamAn Pham
authored andcommitted
temporarily remove presized GHP/GHX tests
1 parent 333a7f9 commit 775b332

1 file changed

Lines changed: 24 additions & 32 deletions

File tree

test/runtests.jl

Lines changed: 24 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -2016,32 +2016,27 @@ else # run HiGHS tests
20162016

20172017
ghp_option_chosen = results["GHP"]["ghp_option_chosen"]
20182018
@test ghp_option_chosen == 2
2019-
@info "GHP test 1"
20202019

20212020
# Test GHP heating and cooling load reduced
20222021
hot_load_reduced_mmbtu = sum(results["GHP"]["space_heating_thermal_load_reduction_with_ghp_mmbtu_per_hour"])
20232022
cold_load_reduced_tonhour = sum(results["GHP"]["cooling_thermal_load_reduction_with_ghp_ton"])
20242023
@test hot_load_reduced_mmbtu 1440.00 atol=0.1
20252024
@test cold_load_reduced_tonhour 761382.78 atol=0.1
2026-
@info "GHP test 2,3"
20272025

20282026
# Test GHP serving space heating with VAV thermal efficiency improvements
20292027
heating_served_mmbtu = sum(s.ghp_option_list[ghp_option_chosen].heating_thermal_kw / REopt.KWH_PER_MMBTU)
20302028
expected_heating_served_mmbtu = 12000 * 0.8 * 0.85 # (fuel_mmbtu * boiler_effic * space_heating_efficiency_thermal_factor)
20312029
@test round(heating_served_mmbtu, digits=1) expected_heating_served_mmbtu atol=1.0
2032-
@info "GHP test 4"
20332030

20342031
# Boiler serves all of the DHW load, no DHW thermal reduction due to GHP retrofit
20352032
boiler_served_mmbtu = sum(results["ExistingBoiler"]["thermal_production_series_mmbtu_per_hour"])
20362033
expected_boiler_served_mmbtu = 3000 * 0.8 # (fuel_mmbtu * boiler_effic)
20372034
@test round(boiler_served_mmbtu, digits=1) expected_boiler_served_mmbtu atol=1.0
2038-
@info "GHP test 5"
20392035

20402036
# LoadProfileChillerThermal cooling thermal is 1/cooling_efficiency_thermal_factor of GHP cooling thermal production
20412037
bau_chiller_thermal_tonhour = sum(s.cooling_load.loads_kw_thermal / REopt.KWH_THERMAL_PER_TONHOUR)
20422038
ghp_cooling_thermal_tonhour = sum(inputs.ghp_cooling_thermal_load_served_kw[1,:] / REopt.KWH_THERMAL_PER_TONHOUR)
20432039
@test round(bau_chiller_thermal_tonhour) ghp_cooling_thermal_tonhour/0.6 atol=1.0
2044-
@info "GHP test 6"
20452040

20462041
# Custom heat pump COP map is used properly
20472042
ghp_option_chosen = results["GHP"]["ghp_option_chosen"]
@@ -2050,7 +2045,6 @@ else # run HiGHS tests
20502045
# Average COP which includes pump power should be lower than Heat Pump only COP specified by the map
20512046
@test heating_cop_avg <= 4.0
20522047
@test cooling_cop_avg <= 8.0
2053-
@info "GHP test 7,8"
20542048

20552049
# Check GHP LCC calculation for URBANopt
20562050
ghp_data = JSON.parsefile("scenarios/ghp_urbanopt.json")
@@ -2074,7 +2068,6 @@ else # run HiGHS tests
20742068
# GHX size must be 0
20752069
@test boreholes 0.0 atol = 0.01
20762070
@test boreholes_len 0.0 atol = 0.01
2077-
@info "GHP test 8-12"
20782071

20792072
# Check GHX LCC calculation for URBANopt
20802073
ghx_data = JSON.parsefile("scenarios/ghx_urbanopt.json")
@@ -2095,37 +2088,36 @@ else # run HiGHS tests
20952088
@test ghp_size 0.0 atol = 0.01
20962089
# LCCC should be around 52% of initial capital cost due to incentive and bonus
20972090
@test ghx_lccc/ghx_lccc_initial 0.518 atol = 0.01
2098-
@info "GHP test 12-15"
20992091

21002092
# User specified GHP size
2101-
input_presizedGHP = deepcopy(input_data)
2102-
input_presizedGHP["GHP"]["max_ton"] = 300
2103-
input_presizedGHP["GHP"]["heatpump_capacity_sizing_factor_on_peak_load"] = 1.0
2104-
delete!(input_presizedGHP["GHP"], "ghpghx_responses")
2105-
# Rerun REopts
2106-
s_presizedGHP = Scenario(input_presizedGHP)
2107-
inputs_presizedGHP = REoptInputs(s_presizedGHP)
2108-
m1 = Model(optimizer_with_attributes(HiGHS.Optimizer, "output_flag" => false, "log_to_console" => false, "mip_rel_gap" => 0.01))
2109-
m2 = Model(optimizer_with_attributes(HiGHS.Optimizer, "output_flag" => false, "log_to_console" => false, "mip_rel_gap" => 0.01))
2110-
results = run_reopt([m1,m2], inputs_presizedGHP)
2111-
# GHP output size should equal user-defined GHP size
2112-
output_GHP_size = sum(results["GHP"]["size_heat_pump_ton"])
2113-
@test output_GHP_size 300.00 atol=0.1
2114-
@info "GHP test 16"
2093+
#input_presizedGHP = deepcopy(input_data)
2094+
#input_presizedGHP["GHP"]["max_ton"] = 300
2095+
#input_presizedGHP["GHP"]["heatpump_capacity_sizing_factor_on_peak_load"] = 1.0
2096+
#delete!(input_presizedGHP["GHP"], "ghpghx_responses")
2097+
## Rerun REopts
2098+
#s_presizedGHP = Scenario(input_presizedGHP)
2099+
#inputs_presizedGHP = REoptInputs(s_presizedGHP)
2100+
#m1 = Model(optimizer_with_attributes(HiGHS.Optimizer, "output_flag" => false, "log_to_console" => false, "mip_rel_gap" => 0.01))
2101+
#m2 = Model(optimizer_with_attributes(HiGHS.Optimizer, "output_flag" => false, "log_to_console" => false, "mip_rel_gap" => 0.01))
2102+
#results = run_reopt([m1,m2], inputs_presizedGHP)
2103+
## GHP output size should equal user-defined GHP size
2104+
#output_GHP_size = sum(results["GHP"]["size_heat_pump_ton"])
2105+
#@test output_GHP_size ≈ 300.00 atol=0.1
21152106

21162107
# User specified max GHP and GHX sizes
2117-
input_presizedGHPGHX = deepcopy(input_presizedGHP)
2118-
input_presizedGHPGHX["GHP"]["max_number_of_boreholes"] = 400
2108+
#input_presizedGHPGHX = deepcopy(input_presizedGHP)
2109+
#input_presizedGHPGHX["GHP"]["max_number_of_boreholes"] = 400
21192110
# Rerun REopts
2120-
s_presizedGHPGHX = Scenario(input_presizedGHPGHX)
2121-
input_presizedGHPGHX = REoptInputs(s_presizedGHPGHX)
2122-
m1 = Model(optimizer_with_attributes(HiGHS.Optimizer, "output_flag" => false, "log_to_console" => false, "mip_rel_gap" => 0.01))
2123-
m2 = Model(optimizer_with_attributes(HiGHS.Optimizer, "output_flag" => false, "log_to_console" => false, "mip_rel_gap" => 0.01))
2124-
results = run_reopt([m1,m2], input_presizedGHPGHX)
2111+
#s_presizedGHPGHX = Scenario(input_presizedGHPGHX)
2112+
#inputs_presizedGHPGHX = REoptInputs(s_presizedGHPGHX)
2113+
#m1 = Model(optimizer_with_attributes(HiGHS.Optimizer, "output_flag" => false, "log_to_console" => false, "mip_rel_gap" => 0.01))
2114+
#m2 = Model(optimizer_with_attributes(HiGHS.Optimizer, "output_flag" => false, "log_to_console" => false, "mip_rel_gap" => 0.01))
2115+
#results = run_reopt([m1,m2], inputs_presizedGHPGHX)
21252116
# GHP output size should equal user-defined GHP size
2126-
output_GHX_size = results["GHP"]["ghpghx_chosen_outputs"]["number_of_boreholes"]
2127-
@test output_GHX_size 400.00 atol=0.9
2128-
@info "GHP test 17"
2117+
#output_GHP_size = results["GHP"]["size_heat_pump_ton"]
2118+
#output_GHX_size = results["GHP"]["ghpghx_chosen_outputs"]["number_of_boreholes"]
2119+
#@test output_GHX_size ≈ 400.00 atol=0.5
2120+
#@test output_GHP_size < 300.00
21292121

21302122
end
21312123

0 commit comments

Comments
 (0)