update pytests to accuracy=high (#594)

* update RADIANCE version loaded by github CI pytests to v6.0

* set accuracy = high for ini_gencumsky.ini

* replace deprecated coactions/setup-xvfb in github pytest.yaml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* correctly pass accuracy= into analysisParamsDict modelchain

* expand acceptance window - high_Azimuth_modelchains

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: cdeline

.github/workflows/pytest.yaml

@@ -1,15 +1,18 @@
-name: test     
+name: test
 
 on: [pull_request, push]
 
+# Force all JavaScript actions to use Node 24 to silence the v4/v5 warnings
+env:
+  FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true
+
 jobs:
   pytest:
-
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false  # don't cancel other matrix jobs when one fails
       matrix:
-        python-version: ["3.8","3.11"]
+        python-version: ["3.8", "3.11"]
         # Test two environments:
         # 1) dependencies with pinned versions from requirements.txt
         # 2) 'pip install --upgrade --upgrade-strategy=eager .' to install upgraded
@@ -31,16 +34,18 @@ jobs:
       with:
         python-version: ${{ matrix.python-version }}
 
-    - name: Install Radiance v5.3
+    - name: Install Radiance v6.0
       run: |
-        wget https://github.com/LBNL-ETA/Radiance/releases/download/012cb178/Radiance_012cb178_Linux.zip -O radiance.zip
+        #wget https://github.com/LBNL-ETA/Radiance/releases/download/012cb178/Radiance_012cb178_Linux.zip -O radiance.zip
+        wget https://github.com/LBNL-ETA/Radiance/releases/download/rad6R0P2/Radiance_c1700d56_Linux.zip -O radiance.zip
         unzip radiance.zip 
-        tar -xvf radiance-5.3.012cb17835-Linux.tar.gz
+        #tar -xvf radiance-5.3.012cb17835-Linux.tar.gz
+        tar -xvf radiance-6.0.c1700d56cc-Linux.tar.gz
         ls -l $PWD
 
     - name: Copy gencumulativesky into radiance /bin
       run: |
-        cp $PWD/bifacial_radiance/data/gencumulativesky $PWD/radiance-5.3.012cb17835-Linux/usr/local/radiance/bin/
+        cp $PWD/bifacial_radiance/data/gencumulativesky $PWD/radiance-6.0.c1700d56cc-Linux/usr/local/radiance/bin/
 
     - name: Install SMARTS 2.9.5
       run: |
@@ -61,17 +66,18 @@ jobs:
     - name: Set environment variables
       run: |
         # https://docs.github.com/en/actions/learn-github-actions/workflow-commands-for-github-actions#adding-a-system-path
-        echo "/home/runner/work/bifacial_radiance/bifacial_radiance/radiance-5.3.012cb17835-Linux/usr/local/radiance/bin" >> $GITHUB_PATH
+        echo "/home/runner/work/bifacial_radiance/bifacial_radiance/radiance-6.0.c1700d56cc-Linux/usr/local/radiance/bin" >> $GITHUB_PATH
         echo "/home/runner/work/bifacial_radiance/bifacial_radiance/SMARTS_295_Linux" >> $GITHUB_PATH
 
+    - name: Install xvfb
+      run: sudo apt-get update && sudo apt-get install -y xvfb
+
     - name: Test with pytest ${{ matrix.env }}
-      uses: coactions/setup-xvfb@6b00cf1889f4e1d5a48635647013c0508128ee1a  # GUI testing requires xvfb
-      with:
-        run: |
-          coverage run -m pytest
-          coverage report
+      run: |
+        xvfb-run -a coverage run -m pytest
+        coverage report
       env:  # environment variables available to this step
-        RAYPATH: .:/home/runner/work/bifacial_radiance/bifacial_radiance/radiance-5.3.012cb17835-Linux/usr/local/radiance/lib
+        RAYPATH: .:/home/runner/work/bifacial_radiance/bifacial_radiance/radiance-6.0.c1700d56cc-Linux/usr/local/radiance/lib
         SMARTSPATH: /home/runner/work/bifacial_radiance/bifacial_radiance/SMARTS_295_Linux
 
     - name: Coveralls

bifacial_radiance/modelchain.py

@@ -166,7 +166,7 @@ def runModelChain(simulationParamsDict, sceneParamsDict, timeControlParamsDict=N
     # Fixed gencumsky condition
         scene = demo.makeScene(module=module, 
                                sceneDict=sceneParamsDict, customtext=customObject)
-        demo.genCumSky(None if use_mtx else demo.gencumsky_metfile, use_mtx=use_mtx) 
+        demo.genCumSky(None if use_mtx else demo.gencumsky_metfile, use_mtx=use_mtx)
 
         if pilesParamsDict:
             demo.addPiles(spacingPiles=pilesParamsDict['spacingPiles'], 
@@ -179,7 +179,8 @@ def runModelChain(simulationParamsDict, sceneParamsDict, timeControlParamsDict=N
         frontscan, backscan = analysis.moduleAnalysis(scene, modWanted=analysisParamsDict['modWanted'],
                                                       rowWanted=analysisParamsDict['rowWanted'],
                                                       sensorsy=analysisParamsDict['sensorsy'])
-        analysis.analysis(octfile, demo.name, frontscan, backscan)
+        analysis.analysis(octfile, demo.name, frontscan, backscan, 
+                          accuracy=analysisParamsDict.get('accuracy', 'low'))
         print('Bifacial ratio yearly average:  %0.3f' %
               (np.mean(analysis.Wm2Back) / np.mean(analysis.Wm2Front)))
 
@@ -222,7 +223,8 @@ def runModelChain(simulationParamsDict, sceneParamsDict, timeControlParamsDict=N
         trackerdict = demo.analysis1axis(trackerdict=trackerdict,
                                          modWanted=analysisParamsDict['modWanted'],
                                          rowWanted=analysisParamsDict['rowWanted'],
-                                         sensorsy=analysisParamsDict['sensorsy'])
+                                         sensorsy=analysisParamsDict['sensorsy'],
+                                         accuracy=analysisParamsDict.get('accuracy', 'low'))
 
         # TODO: Chris, not all functions were saving/returning analysis before. 
                # It is also not a very good return as it will only include the last key