Skip to content

Commit 8c76450

Browse files
authored
bug fix in analyzeRow. Fixes #572 (#574)
* bug fix in analyzeRow. Fixes #572 * update SMARTS download URL * update .readthedocs.yml to include link to conf.py
1 parent db4bb4a commit 8c76450

3 files changed

Lines changed: 7 additions & 2 deletions

File tree

.github/workflows/pytest.yaml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,8 @@ jobs:
4444
4545
- name: Install SMARTS 2.9.5
4646
run: |
47-
wget https://www.nrel.gov/grid/solar-resource/assets/data/smarts-295-linux-tar.gz -O /tmp/smarts.tar.gz
47+
wget 'https://www.nrel.gov/media/docs/libraries/grid/smarts-295-linux-tar.gz?sfvrsn=ef08b59d_1&download=true' -O /tmp/smarts.tar.gz
48+
#wget https://www.nrel.gov/grid/solar-resource/assets/data/smarts-295-linux-tar.gz -O /tmp/smarts.tar.gz
4849
tar -xvf /tmp/smarts.tar.gz
4950
unlink $PWD/SMARTS_295_Linux/smarts295bat
5051
sed -i 's/batch=.FALSE./batch=.TRUE./g' $PWD/SMARTS_295_Linux/Source_code/smarts295.f

.readthedocs.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
version: 2
22

3+
sphinx:
4+
# Path to your Sphinx configuration file.
5+
configuration: docs/sphinx/source/conf.py
6+
37
build:
48
os: ubuntu-20.04
59
tools:

bifacial_radiance/main.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4415,7 +4415,7 @@ def analyzeRow(self, octfile, scene, rowWanted=None, name=None,
44154415
nMods = scene.sceneDict['nMods']
44164416

44174417
if rowWanted == None:
4418-
rowWanted = round(self.nRows / 1.99)
4418+
rowWanted = round(scene.sceneDict['nRows']/ 1.99)
44194419
df_dict_row = {}
44204420
row_keys = ['x','y','z','rearZ','mattype','rearMat','Wm2Front','Wm2Back','Back/FrontRatio']
44214421
dict_row = df_dict_row.fromkeys(row_keys)

0 commit comments

Comments
 (0)