The quest to Patch Bytes/Instructions easily

[Smileynator]

Is your feature request related to a problem? Please describe.
An easier way to create/manage/remove patched bytes.
Current flow issues:
Being allowed to edit bytes that are code, is prohibited for some reason, patching instructions is your only way.
Patching an instruction itself is great, it adjust the code flow, reprocesses the C++ as well.
Now leave the project for a week, and see if you can remember what you patched and where, and what the original opcodes were.
Even if you had a backup of your file, Ghidra remembered your patch somewhere, and will refuse to show the old opcodes.

Describe the solution you'd like

1. Allow people to edit bytes marked as code. I am not sure why this is blocked by default and has no option i could find to turn it off.
2. Since patches are stored somewhere anyway, might as well make a view somewhere that shows what patches were made, old bytes/new bytes, old operator(s) new operator(s).
3. Allow the reversing of said patches as well, to make the undo of a patch you were testing out easier to do.

Current flow for restoring a patch that is no longer in Undo: Clear marking of code, restore old bytes since you forgot the old opcodes most likely in the bytes window, then select the whole function and ask ghidra to "Clear flow and repair" which is not that obvious a path. (which i am not even sure correctly works all the time)

Describe alternatives you've considered
I would edit my bytecode outside of Ghidra, but like i said, Ghidra doesn't care much about this change, and any patches you did in ghidra will come out on top of whatever the underlying file says it should be. Resulting in a disconnect in what the bytecode actually is. Debugging would be problematic, and C++ previews broken or unusable from that point onward.

[Wall-AF]

1. Allow people to edit bytes marked as code. I am not sure why this is blocked by default and has no option i could find to turn it off.

If you clear the assembly, you can then edit those bytes using the Byte Editor.

[Wall-AF]

Forgot to mention it still won't remember the original bytes though, you currently need to do something like create a comment.

[ryanmkurtz]

Expands on #3789

[Smileynator]

1. Allow people to edit bytes marked as code. I am not sure why this is blocked by default and has no option i could find to turn it off.

If you clear the assembly, you can then edit those bytes using the Byte Editor.

I did mention this, just after point 3. I am aware of the workaround, but it is anything but helpful to have to do it this way.

[ghidra007]

1. Allow people to edit bytes marked as code. I am not sure why this is blocked by default and has no option i could find to turn it off.

If you clear the assembly, you can then edit those bytes using the Byte Editor.

I did mention this, just after point 3. I am aware of the workaround, but it is anything but helpful to have to do it this way.

The reason it is this way is because changing the bytes could change the number of lines of code. So you have to clear the code then edit then redisassemble.

Regarding your other two comments, I believe using the add to version control feature would get you both of the things you want as you would be able to diff two versions of your binary and you would also be able to revert to a previous version if needed the whole thing reverted or select a particular difference and copy it back over to your current program.

One thing many people don't realize is that you don't need to create a shared repository if you just want to version your own programs. You just need to right mouse on the program from the project manager and choose "Add to Version Control" you will be allowed/expected to add a comment regarding what is in that check in. Any future saved changes can be added to version control by doing a check in from the project manager with a new comment. To see the check-in comment history you just right mouse on your program and choose Show History... Any item in the resulting list can be opened in a code browser to look at. You can also do diffs between different versions from the code browser by using the Tools-Program Differences... Notice that there is a Show History button at the bottom of the select other program window. If you click on that you will see a list of your check ins with their comments and you can choose any of them to diff against.

To narrow in on byte differences, just select bytes only when doing the diff.

Hope this helps.