feat: audit "as any as" usage and prefer it over "as unknown as" (#144)

frodi-karlsson · web-flow · commit b6d6b1ff787a · 2026-06-04T08:15:59.000+02:00
diff --git a/packages/airtable-lib/src/connector/airtableRemoteConnector.ts b/packages/airtable-lib/src/connector/airtableRemoteConnector.ts
@@ -16,30 +16,31 @@ import { AirtableTableDao } from '../airtableTableDao.js'
 
 export const AIRTABLE_CONNECTOR_REMOTE = Symbol('AIRTABLE_CONNECTOR_JSON')
 
-export class AirtableRemoteConnector<BASE = any> implements AirtableConnector<BASE> {
+export class AirtableRemoteConnector<
+  BASE extends Record<keyof BASE, AirtableRecord[]>,
+> implements AirtableConnector<BASE> {
   constructor(private airtableLib: AirtableLib) {}
 
   readonly TYPE = AIRTABLE_CONNECTOR_REMOTE
 
   async fetch(baseDaoCfg: AirtableBaseDaoCfg<BASE>, opt: AirtableDaoOptions = {}): Promise<BASE> {
     const { tableCfgMap } = baseDaoCfg
 
-    const base = {} as BASE
+    const base: Record<string, AirtableRecord[]> = {}
 
     await pMap(
       Object.keys(tableCfgMap),
       async tableName => {
-        ;(base as any)[tableName] = await this.getTableDao(
-          baseDaoCfg,
-          tableName as keyof BASE,
-        ).getRecords(opt)
+        base[tableName] = await this.getTableDao(baseDaoCfg, tableName as keyof BASE).getRecords(
+          opt,
+        )
       },
       {
         concurrency: opt.concurrency || 4,
       },
     )
 
-    return base
+    return base as BASE
   }
 
   /**
@@ -71,7 +72,7 @@ export class AirtableRemoteConnector<BASE = any> implements AirtableConnector<BA
 
         // One-by-one to preserve order
         await pMap(
-          base[tableName] as any as AirtableRecord[],
+          base[tableName],
           async _r => {
             const oldId = _r.airtableId
 
@@ -112,7 +113,7 @@ export class AirtableRemoteConnector<BASE = any> implements AirtableConnector<BA
       async tableName => {
         const dao = this.getTableDao(baseDaoCfg, tableName)
 
-        const records = (base[tableName] as any as AirtableRecord[])
+        const records = base[tableName]
           // Only records with non-empty array values
           .filter(r => Object.values(r).some(v => isArrayOfLinks(v)))
 
@@ -124,7 +125,7 @@ export class AirtableRemoteConnector<BASE = any> implements AirtableConnector<BA
             let patch: AirtableRecord = _filterObject(r, (_k, v) => isArrayOfLinks(v))
             // console.log({patch1: patch})
             // use idMap
-            patch = _mapValues(patch, (_k, v) => (v as any as string[]).map(oldId => idMap[oldId]))
+            patch = _mapValues(patch, (_k, v) => (v as any).map((oldId: string) => idMap[oldId]))
             // console.log({patch2: patch})
             await dao.updateRecord(idMap[airtableId]!, patch, opt)
           },
diff --git a/packages/db-lib/src/timeseries/commonTimeSeriesDao.ts b/packages/db-lib/src/timeseries/commonTimeSeriesDao.ts
@@ -83,7 +83,7 @@ export class CommonTimeSeriesDao {
     if (q.fromIncl) dbq.filter('ts', '>=', q.fromIncl)
     if (q.toExcl) dbq.filter('ts', '<', q.toExcl)
 
-    const rows = (await this.cfg.db.runQuery(dbq)).rows as any as TimeSeriesRow[]
+    const rows = (await this.cfg.db.runQuery(dbq)).rows as TimeSeriesRow[]
 
     // todo: query from aggregated tables when step is above 'hour'
 
diff --git a/packages/dev-lib/cfg/oxlint-plugin-stylistic.js b/packages/dev-lib/cfg/oxlint-plugin-stylistic.js
diff --git a/packages/dev-lib/cfg/oxlint.config.js b/packages/dev-lib/cfg/oxlint.config.js
@@ -39,7 +39,7 @@ export const sharedConfig = {
     // "vue",
     'vitest',
   ],
-  jsPlugins: [`${import.meta.dirname}/oxlint-plugin-stylistic.mjs`],
+  jsPlugins: [`${import.meta.dirname}/oxlint-plugin-stylistic.js`],
   options: {
     reportUnusedDisableDirectives: 'deny',
     respectEslintDisableDirectives: false,
diff --git a/packages/dev-lib/src/test/cfg/oxlint.config.dump.json b/packages/dev-lib/src/test/cfg/oxlint.config.dump.json
@@ -1,6 +1,6 @@
 {
   "plugins": ["unicorn", "typescript", "oxc", "import", "jsdoc", "vitest", "promise", "node"],
-  "jsPlugins": ["cfg/oxlint-plugin-stylistic.mjs"],
+  "jsPlugins": ["cfg/oxlint-plugin-stylistic.js"],
   "categories": {},
   "rules": {
     "complexity": [
diff --git a/packages/dev-lib/src/vendor/mitm.ts b/packages/dev-lib/src/vendor/mitm.ts
@@ -1,14 +1,15 @@
+import type * as HttpType from 'node:http'
+import type * as HttpsType from 'node:https'
+import { createRequire } from 'node:module'
+import type * as NetType from 'node:net'
+import type * as TlsType from 'node:tls'
 /**
  * Minimal vendored implementation of the `mitm` package.
  * Only supports the "connect" event with bypass() and disable() - that's all testOffline needs.
  *
  * Based on: https://github.com/moll/node-mitm
  */
-import type * as HttpType from 'node:http'
-import type * as HttpsType from 'node:https'
-import { createRequire } from 'node:module'
-import type * as NetType from 'node:net'
-import type * as TlsType from 'node:tls'
+import type { AnyObject } from '@naturalcycles/js-lib/types'
 
 // Use require() to get mutable module objects (ESM namespace objects are frozen)
 const require = createRequire(import.meta.url)
@@ -116,7 +117,7 @@ export function createMitm(): Mitm {
     return function (...args: Parameters<typeof Tls.connect>): TlsType.TLSSocket {
       const [opts, done] = normalizeArgs(args)
       return connect(
-        orig as unknown as (...a: unknown[]) => NetType.Socket,
+        orig as (...a: unknown[]) => TlsType.TLSSocket,
         opts,
         done,
       ) as TlsType.TLSSocket
@@ -129,12 +130,12 @@ export function createMitm(): Mitm {
 
   stub(Net, 'connect', netConnect)
   stub(Net, 'createConnection', netConnect)
-  stub(Http.Agent.prototype as unknown as Record<string, unknown>, 'createConnection', netConnect)
+  stub(Http.Agent.prototype as AnyObject, 'createConnection', netConnect)
   stub(Tls, 'connect', tlsConnect)
 
   // Disable keep-alive on global agents to force new connections
-  const httpAgent = Http.globalAgent as unknown as Record<string, unknown>
-  const httpsAgent = Https.globalAgent as unknown as Record<string, unknown>
+  const httpAgent = Http.globalAgent as AnyObject
+  const httpsAgent = Https.globalAgent as AnyObject
   if (httpAgent['keepAlive']) {
     stub(httpAgent, 'keepAlive', false)
   }
diff --git a/packages/js-lib/src/decorators/logMethod.decorator.test.ts b/packages/js-lib/src/decorators/logMethod.decorator.test.ts
@@ -97,7 +97,7 @@ test('methodReturnsArray', () => {
 })
 
 test('instanceId', () => {
-  const c = new C()
-  ;(c as any as InstanceId).instanceId = 'instance_1'
+  const c = new C() as C & InstanceId
+  c.instanceId = 'instance_1'
   c.syncMethodSuccess()
 })
diff --git a/packages/js-lib/src/object/keySortedMap.ts b/packages/js-lib/src/object/keySortedMap.ts
@@ -151,7 +151,7 @@ export class KeySortedMap<K, V> {
   forEach(cb: (value: V, key: K, map: Map<K, V>) => void, thisArg?: any): void {
     const { map } = this
     for (const k of this.#sortedKeys) {
-      cb.call(thisArg, map.get(k)!, k, this as unknown as Map<K, V>)
+      cb.call(thisArg, map.get(k)!, k, this)
     }
   }
 
diff --git a/packages/js-lib/src/object/lazyKeySortedMap.ts b/packages/js-lib/src/object/lazyKeySortedMap.ts
@@ -128,7 +128,7 @@ export class LazyKeySortedMap<K, V> {
   forEach(cb: (value: V, key: K, map: Map<K, V>) => void, thisArg?: any): void {
     const { map } = this
     for (const k of this.getSortedKeys()) {
-      cb.call(thisArg, map.get(k)!, k, this as unknown as Map<K, V>)
+      cb.call(thisArg, map.get(k)!, k, this)
     }
   }
 
diff --git a/packages/mongo-lib/src/mongo.db.ts b/packages/mongo-lib/src/mongo.db.ts
@@ -153,16 +153,16 @@ export class MongoDB extends BaseCommonDB implements CommonDB, AsyncDisposable {
     if (!ids.length) return []
 
     const client = await this.client()
-    const items = (await client
+    const items = await client
       .db(this.cfg.db)
-      .collection(table)
+      .collection<MongoObject<ROW>>(table)
       .find({
         _id: {
           $in: ids as any[],
         },
       })
-      .toArray()) as any as MongoObject<ROW>[]
-    return items.map(i => this.mapFromMongo(i))
+      .toArray()
+    return items.map(i => this.mapFromMongo(i as MongoObject<ROW>))
   }
 
   override async deleteByIds(
@@ -195,11 +195,11 @@ export class MongoDB extends BaseCommonDB implements CommonDB, AsyncDisposable {
     const client = await this.client()
     const { query, options } = dbQueryToMongoQuery(q)
 
-    const items = (await client
+    const items = await client
       .db(this.cfg.db)
       .collection<ROW>(q.table)
       .find(query, options)
-      .toArray()) as any as MongoObject<ROW>[]
+      .toArray()
 
     let rows = items.map(i => this.mapFromMongo(i as any))
 
diff --git a/packages/nodejs-lib/src/validation/ajv/jSchema.ts b/packages/nodejs-lib/src/validation/ajv/jSchema.ts
@@ -414,7 +414,7 @@ export class JSchema<OUT, Opt>
    * The usage of this function is discouraged as it defeats the purpose of having type-safe validation.
    */
   castAs<T>(): JSchema<T, Opt> {
-    return this as unknown as JSchema<T, Opt>
+    return this as any as JSchema<T, Opt>
   }
 
   /**
@@ -529,7 +529,7 @@ export class JSchema<OUT, Opt>
     const clone = this.cloneAndUpdateSchema({
       postValidation: fn,
     })
-    return clone as unknown as JSchema<OUT2, Opt>
+    return clone as any as JSchema<OUT2, Opt>
   }
 
   /**
@@ -557,7 +557,7 @@ export class JBuilder<OUT, Opt> extends JSchema<OUT, Opt> {
    * The usage of this function is discouraged as it defeats the purpose of having type-safe validation.
    */
   override castAs<T>(): JBuilder<T, Opt> {
-    return this as unknown as JBuilder<T, Opt>
+    return this as any as JBuilder<T, Opt>
   }
 
   $schema($schema: string): this {
@@ -683,7 +683,7 @@ export class JBuilder<OUT, Opt> extends JSchema<OUT, Opt> {
     const { customValidations = [] } = this.schema
     return this.cloneAndUpdateSchema({
       customValidations: [...customValidations, validator],
-    }) as unknown as JBuilder<OUT2, Opt>
+    }) as any as JBuilder<OUT2, Opt>
   }
 
   /**
@@ -700,7 +700,7 @@ export class JBuilder<OUT, Opt> extends JSchema<OUT, Opt> {
     const { customConversions = [] } = this.schema
     return this.cloneAndUpdateSchema({
       customConversions: [...customConversions, converter],
-    }) as unknown as JBuilder<OUT2, Opt>
+    }) as any as JBuilder<OUT2, Opt>
   }
 }
 
@@ -783,7 +783,7 @@ export class JString<
   }
 
   branded<B extends string>(): JString<B, Opt> {
-    return this as unknown as JString<B, Opt>
+    return this as any as JString<B, Opt>
   }
 
   /**
@@ -934,7 +934,7 @@ export class JNumber<
   }
 
   branded<B extends number>(): JNumber<B, Opt> {
-    return this as unknown as JNumber<B, Opt>
+    return this as any as JNumber<B, Opt>
   }
 
   multipleOf(multipleOf: number): this {
@@ -1131,7 +1131,7 @@ export class JObject<OUT extends AnyObject, Opt extends boolean = false> extends
     const clone = this.clone()
     mergeJsonSchemaObjects(clone.schema as any, other.schema as any)
     _objectAssign(clone.schema, { hasIsOfTypeCheck: false })
-    return clone as unknown as JObject<OUT & OUT2, false>
+    return clone as JObject<OUT & OUT2, false>
   }
 
   /**
@@ -1229,7 +1229,7 @@ export class JObjectInfer<
     // the new schema loses that quality.
     _objectAssign(newBuilder.schema, { hasIsOfTypeCheck: false })
 
-    return newBuilder as unknown as JObjectInfer<
+    return newBuilder as any as JObjectInfer<
       {
         [K in keyof PROPS | keyof NEW_PROPS]: K extends keyof NEW_PROPS
           ? NEW_PROPS[K]
@@ -1321,7 +1321,7 @@ export class JEnum<
   }
 
   branded<B extends OUT>(): JEnum<B, Opt> {
-    return this as unknown as JEnum<B, Opt>
+    return this as any as JEnum<B, Opt>
   }
 }
 
diff --git a/packages/sqlite-lib/src/sqliteKeyValueDB.ts b/packages/sqlite-lib/src/sqliteKeyValueDB.ts
@@ -110,7 +110,7 @@ export class SqliteKeyValueDB implements CommonKeyValueDB, CommonSyncKeyValueDB,
   getByIdsSync(table: string, ids: string[]): KeyValueDBTuple[] {
     const sql = `SELECT id,v FROM ${table} where id in (${ids.map(id => `'${id}'`).join(',')})`
     if (this.cfg.debug) this.cfg.logger.log(sql)
-    const rows = this.db.prepare(sql).all() as unknown as KeyValueObject[]
+    const rows = this.db.prepare(sql).all() as any as KeyValueObject[]
     return rows.map(r => [r.id, Buffer.from(r.v)])
   }
 

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"plugins": ["unicorn", "typescript", "oxc", "import", "jsdoc", "vitest", "promise", "node"],`
`3`		`- "jsPlugins": ["cfg/oxlint-plugin-stylistic.mjs"],`
	`3`	`+ "jsPlugins": ["cfg/oxlint-plugin-stylistic.js"],`
`4`	`4`	`"categories": {},`
`5`	`5`	`"rules": {`
`6`	`6`	`"complexity": [`
Original file line number	Diff line number	Diff line change
`@@ -151,7 +151,7 @@ export class KeySortedMap<K, V> {`
`151`	`151`	`forEach(cb: (value: V, key: K, map: Map<K, V>) => void, thisArg?: any): void {`
`152`	`152`	`const { map } = this`
`153`	`153`	`for (const k of this.#sortedKeys) {`
`154`		`- cb.call(thisArg, map.get(k)!, k, this as unknown as Map<K, V>)`
	`154`	`+ cb.call(thisArg, map.get(k)!, k, this)`
`155`	`155`	`}`
`156`	`156`	`}`
`157`	`157`
Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,7 @@ export class LazyKeySortedMap<K, V> {`
`128`	`128`	`forEach(cb: (value: V, key: K, map: Map<K, V>) => void, thisArg?: any): void {`
`129`	`129`	`const { map } = this`
`130`	`130`	`for (const k of this.getSortedKeys()) {`
`131`		`- cb.call(thisArg, map.get(k)!, k, this as unknown as Map<K, V>)`
	`131`	`+ cb.call(thisArg, map.get(k)!, k, this)`
`132`	`132`	`}`
`133`	`133`	`}`
`134`	`134`