Skip to content

Commit 15595ff

Browse files
committed
Remove hardcoded image_shape from config.py
I previously pushed some updates that lets df3d determine the input image size by just looking at the first image file, but I left the default image size in config until being sure this worked. We've now run df3d a lot on input images that have different sizes, and it works. Running on different input sizes requires the user to _either_ update the df3d.config['image_shape'] value for each dataset, or delete that value which allows it to be automatically inferred. So let's just delete the default value so that it can always automatically be inferred.
1 parent 070e753 commit 15595ff

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

df3d/config.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
config_fly = {
1616
"name": "fly",
1717
"num_cameras": 7,
18-
"image_shape": [960, 480],
1918
"heatmap_shape": [64, 128],
2019
"left_cameras": [0, 1, 2],
2120
"right_cameras": [6, 5, 4],

df3d/core.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ def __init__(
9696
f" config.py image shape {self.image_shape}")
9797
self.image_shape = config["image_shape"] = image0_shape
9898
if not hasattr(self, "image_shape"):
99-
raise ValueError("Image shape not specified in config and could"
99+
raise ValueError("Image shape not specified in df3d.config and could"
100100
f" not be read from {image0_path}")
101101

102102
self.db = PoseDB(self.output_folder)

0 commit comments

Comments
 (0)