fix(config): treat empty backup dir as unset

Author: NeapolitanIcecream

recoleta/config.py

@@ -1637,6 +1637,8 @@ def _normalize_db_path(cls, value: str | Path) -> Path:
     def _normalize_optional_path(cls, value: str | Path | None) -> Path | None:
         if value is None:
             return None
+        if isinstance(value, str) and not value.strip():
+            return None
         return Path(value).expanduser().resolve()
 
     @field_validator("rag_lancedb_dir", mode="before")

tests/test_recoleta_specs_maintenance_cli.py

@@ -353,6 +353,38 @@ def test_admin_backup_honors_env_backup_output_dir_when_settings_are_skipped(
     assert (bundle_dirs[0] / "manifest.json").exists()
 
 
+def test_admin_backup_falls_back_when_configured_backup_output_dir_is_empty(
+    tmp_path: Path,
+) -> None:
+    runner = CliRunner()
+    db_path = tmp_path / "recoleta.db"
+    config_path = tmp_path / "recoleta.yaml"
+    config_path.write_text(
+        "\n".join(
+            [
+                f'RECOLETA_DB_PATH: "{db_path}"',
+                'LLM_MODEL: "openai/gpt-4o-mini"',
+                'BACKUP_OUTPUT_DIR: ""',
+            ]
+        ),
+        encoding="utf-8",
+    )
+
+    repository = Repository(db_path=db_path)
+    repository.init_schema()
+
+    result = runner.invoke(
+        recoleta.cli.app,
+        ["admin", "backup", "--config", str(config_path)],
+    )
+
+    assert result.exit_code == 0
+    fallback_root = (db_path.parent / "backups").resolve()
+    bundle_dirs = [path for path in fallback_root.iterdir() if path.is_dir()]
+    assert len(bundle_dirs) == 1
+    assert (bundle_dirs[0] / "manifest.json").exists()
+
+
 def test_restore_exits_when_workspace_lock_is_held(tmp_path: Path) -> None:
     runner = CliRunner()
     db_path = tmp_path / "recoleta.db"

tests/test_recoleta_specs_settings.py

@@ -48,6 +48,20 @@ def test_settings_loads_backup_output_dir_from_env(
     assert settings.backup_output_dir == backup_root.resolve()
 
 
+def test_settings_treats_empty_backup_output_dir_env_as_unset(
+    monkeypatch: pytest.MonkeyPatch, tmp_path: Path
+) -> None:
+    monkeypatch.delenv("RECOLETA_CONFIG_PATH", raising=False)
+    monkeypatch.setenv("RECOLETA_DB_PATH", str(tmp_path / "recoleta.db"))
+    monkeypatch.setenv("LLM_MODEL", "openai/gpt-4o-mini")
+    monkeypatch.setenv("PUBLISH_TARGETS", "markdown")
+    monkeypatch.setenv("BACKUP_OUTPUT_DIR", "")
+
+    settings = Settings()  # pyright: ignore[reportCallIssue]
+
+    assert settings.backup_output_dir is None
+
+
 def test_settings_rejects_configured_source_without_enabled(
     configured_env, monkeypatch: pytest.MonkeyPatch
 ) -> None: