fix lint

Author: olga24912

contracts/satoshi-bridge/src/account.rs

@@ -107,10 +107,9 @@ impl Contract {
     }
 
     pub fn internal_unwrap_account(&self, account_id: &AccountId) -> Account {
-        self.internal_get_account(account_id)
-            .unwrap_or_else(|| {
-                env::panic_str(&format!("ERR_ACCOUNT_NOT_REGISTERED: {}", account_id))
-            })
+        self.internal_get_account(account_id).unwrap_or_else(|| {
+            env::panic_str(&format!("ERR_ACCOUNT_NOT_REGISTERED: {}", account_id))
+        })
     }
 
     pub fn internal_unwrap_mut_account(&mut self, account_id: &AccountId) -> &mut Account {

contracts/satoshi-bridge/src/api/management.rs

@@ -202,10 +202,7 @@ impl Contract {
     pub fn remove_unlimited_txs_white_list(&mut self, account_ids: Vec<AccountId>) {
         assert_one_yocto();
         for account_id in account_ids {
-            let is_success = self
-                .data_mut()
-                .unlimited_txs_white_list
-                .remove(&account_id);
+            let is_success = self.data_mut().unlimited_txs_white_list.remove(&account_id);
             require!(is_success, format!("Invalid account_id: {}", account_id));
         }
     }

contracts/satoshi-bridge/src/btc_pending_info.rs

@@ -393,7 +393,7 @@ impl Contract {
 
 pub fn generate_btc_pending_sign_id(payload_preimages: &[Vec<u8>]) -> String {
     let hash_bytes = env::sha256_array(
-        &payload_preimages
+        payload_preimages
             .iter()
             .flatten()
             .copied()

contracts/satoshi-bridge/src/zcash_utils/contract_methods.rs

@@ -1,3 +1,5 @@
+#![allow(clippy::too_many_arguments)]
+
 use crate::psbt_wrapper::PsbtWrapper;
 use crate::zcash_utils::types::ChainSpecificData;
 use crate::*;
@@ -19,7 +21,7 @@ macro_rules! define_rbf_callback {
                 chain_specific_data: Option<ChainSpecificData>,
             ) {
                 let predecessor_account_id = env::predecessor_account_id();
-                self.get_last_block_height_promise().then(
+                let _ = self.get_last_block_height_promise().then(
                     Self::ext(env::current_account_id())
                         .with_static_gas(GAS_RBF_CALL_BACK)
                         .$callback_name(
@@ -249,7 +251,7 @@ impl Contract {
         input: Vec<OutPoint>,
         output: Vec<TxOut>,
     ) {
-        self.get_last_block_height_promise().then(
+        let _ = self.get_last_block_height_promise().then(
             Self::ext(env::current_account_id())
                 .with_static_gas(GAS_FOR_ACTIVE_UTXO_MANAGMENT_CALLBACK)
                 .active_utxo_management_callback(account_id, input, output),

contracts/satoshi-bridge/tests/test_upgrade.rs

@@ -107,6 +107,19 @@ async fn test_btc_bridge_upgrade_from_v0_7_5_account_migration() {
         upgrade_context.root.id().as_str()
     );
     assert!(account.btc_pending_sign_ids.is_empty());
+
+    // get_accounts_paged must also handle V0 accounts without panicking.
+    let accounts: std::collections::HashMap<near_sdk::AccountId, Account> = upgrade_context
+        .previous_satoshi_bridge_contract
+        .call("get_accounts_paged")
+        .args_json(json!({}))
+        .view()
+        .await
+        .unwrap()
+        .json()
+        .unwrap();
+
+    assert_eq!(accounts.len(), 1);
 }
 
 #[tokio::test]