enh: improve db pink line node handling and submission features

- Added feature_type "pink_line_node" to createPinkLineNode and updated submission logic to include this type.
- Refactored type definitions to accommodate the new feature type in various functions.
- Improved filtering logic for pink line routes in submission batch summaries.

Author: noamjgal

src/supabase/pinkLine.ts

@@ -29,6 +29,7 @@ export async function createPinkLineNode(
         geom: pointGeoJSON,
         project_id: projectId,
         submission_id: null,
+        feature_type: "pink_line_node",
       },
     ])
     .select("id")
@@ -104,7 +105,7 @@ export async function submitPinkLineRoute(
 
   const { error } = await supabase
     .from("geo_features")
-    .update({ submission_id: submissionId })
+    .update({ submission_id: submissionId, feature_type: "pink_line_node" })
     .in("id", nodeIds)
     .eq("project_id", projectId);
 

src/supabase/submissionBatches.ts

@@ -57,9 +57,13 @@ type SubmissionBatchRow = SubmissionBatchListRow & {
 type GeoFeatureCountRow = {
   submission_id: string;
   project_id: string;
-  feature_type: MemorialFeatureType | null;
+  feature_type: string | null;
 };
 
+function isLegacyOrTaggedPinkNode(featureType: string | null): boolean {
+  return featureType === null || featureType === "pink_line_node";
+}
+
 /** PostgREST default row cap; paginate reads to avoid truncated lists and wrong counts. */
 const GEO_FEATURES_PAGE_SIZE = 1000;
 
@@ -152,6 +156,7 @@ export async function listSubmissionBatchSummariesForMapContext(
     if (!bucket) continue;
 
     if (pinkProjectId && r.project_id === pinkProjectId) {
+      if (r.feature_type === "pink_line_route") continue;
       bucket.pinkNodeCount += 1;
     } else if (memorialProjectId && r.project_id === memorialProjectId) {
       if (r.feature_type === "central") bucket.memorialCentralCount += 1;
@@ -232,6 +237,7 @@ export async function listSubmissionBatchSummariesForWorkspace(
     if (!bucket) continue;
 
     if (pinkProjectId && r.project_id === pinkProjectId) {
+      if (r.feature_type === "pink_line_route") continue;
       bucket.pinkNodeCount += 1;
     } else if (memorialProjectId && r.project_id === memorialProjectId) {
       if (r.feature_type === "central") bucket.memorialCentralCount += 1;
@@ -287,7 +293,7 @@ export async function loadSubmissionBatchMapDetail(
     description: string | null;
     geom: unknown;
     project_id: string;
-    feature_type: MemorialFeatureType | null;
+    feature_type: string | null;
     created_at: string | null;
   };
 
@@ -312,6 +318,7 @@ export async function loadSubmissionBatchMapDetail(
     const tempId = `gf-${row.id}`;
 
     if (pinkProjectId && row.project_id === pinkProjectId) {
+      if (!isLegacyOrTaggedPinkNode(row.feature_type)) continue;
       pinkNodes.push({
         tempId,
         name: row.name,

src/supabase/unifiedSubmission.ts

@@ -76,15 +76,15 @@ function buildGeoFeatureRows(
   name: string;
   description: string;
   geom: GeoJSON;
-  feature_type?: MemorialFeatureType;
+  feature_type?: MemorialFeatureType | "pink_line_node";
 }> {
   const rows: Array<{
     project_id: string;
     submission_id: string;
     name: string;
     description: string;
     geom: GeoJSON;
-    feature_type?: MemorialFeatureType;
+    feature_type?: MemorialFeatureType | "pink_line_node";
   }> = [];
 
   if (params.includePink) {
@@ -99,6 +99,7 @@ function buildGeoFeatureRows(
         name: node.name?.trim() || "Pink Line Node",
         description: node.description?.trim() || "",
         geom: { type: "Point", coordinates: [node.lng, node.lat] } as GeoJSON,
+        feature_type: "pink_line_node" as const,
       }))
     );
   }
@@ -131,7 +132,7 @@ function rowsToRpcPayload(
   description: string;
   lng: number;
   lat: number;
-  feature_type: MemorialFeatureType | null;
+  feature_type: MemorialFeatureType | "pink_line_node" | null;
 }> {
   return rows.map((r) => {
     const g = r.geom as GeoJSON.Point;