Remove problematic similar + zero methods for MatRingElem

Author: fingolfin

src/MatRing.jl

@@ -93,14 +93,6 @@ end
 
 similar(x::MatRingElem, n::Int) = similar(x, base_ring(x), n)
 
-# TODO: deprecate these:
-function similar(x::MatRingElem{T}, R::NCRing, m::Int, n::Int) where T <: NCRingElement
-   m != n && error("Dimensions don't match in similar")
-   return similar(x, R, n)
-end
-
-similar(x::MatRingElem, m::Int, n::Int) = similar(x, base_ring(x), m, n)
-
 @doc raw"""
     zero(x::MatRingElem, R::NCRing, n::Int)
     zero(x::MatRingElem, R::NCRing)
@@ -113,10 +105,6 @@ with defaults based upon the given source matrix ring element `x`.
 zero(x::MatRingElem, R::NCRing=base_ring(x), n::Int=degree(x)) = zero!(similar(x, R, n))
 zero(x::MatRingElem, n::Int) = zero!(similar(x, n))
 
-# TODO: deprecate these
-zero(x::MatRingElem, R::NCRing, r::Int, c::Int) = zero!(similar(x, R, r, c))
-zero(x::MatRingElem, r::Int, c::Int) = zero!(similar(x, r, c))
-
 iszero(a::MatRingElem{T}) where T <: NCRingElement = iszero(matrix(a))
 
 one(a::MatRingElem{T}) where T <: NCRingElement = one(parent(a))

test/generic/MatRing-test.jl

@@ -185,8 +185,8 @@ end
    @test isempty(M) == false
    @test isassigned(M, 1, 1) == true
 
-   @test iszero(zero(M, 3, 3))
-   @test iszero(zero(M, QQ, 3, 3))
+   @test iszero(zero(M, 3))
+   @test iszero(zero(M, QQ, 3))
    @test iszero(zero(M, QQ))
 
    M = zero!(M)
@@ -1571,11 +1571,6 @@ end
       @test !test_zero || iszero(n)
       @test parent(n) == matrix_ring(R, r)
       @test size(n) == (r, r)
-      nn = sim_zero(m, r, r)
-      @test !test_zero || iszero(nn)
-      @test parent(nn) == matrix_ring(R, r)
-      @test size(nn) == (r, r)
-      @test_throws ErrorException sim_zero(m, r, r+1)
       for S = [QQ, ZZ, GF(2), GF(5)]
          n = sim_zero(m, S)
          @test !test_zero || iszero(n)
@@ -1586,11 +1581,6 @@ end
          @test !test_zero || iszero(n)
          @test parent(n) == matrix_ring(S, r)
          @test size(n) == (r, r)
-         n = sim_zero(m, S, r, r)
-         @test !test_zero || iszero(n)
-         @test parent(n) == matrix_ring(S, r)
-         @test size(n) == (r, r)
-         @test_throws ErrorException sim_zero(m, S, r, r+2)
       end
    end
 end