Skip to content

Conversation

@JohnAAbbott
Copy link
Collaborator

The patches change just 2 lines, but I renamed the args to _solve_tril! so that they correspond to the "doc" in the comment right before the function (and also coherent with _solve_triu). The tests are now with 3x3 matrices since the old buggy code happened to work with 2x2 matrices.

@JohnAAbbott
Copy link
Collaborator Author

I note that currently the documentation for _solve_triu is in AbstractAlgebra; in particular near line 3498 in the file src/Matrix.jl there is the following:

# Remove the following once Nemo is adjusted
_solve_triu_right(M, b; unipotent = false) = _solve_triu(M, b; unipotent, side = :right)

There is apparently no documentation for _solve_tril!

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 88.17%. Comparing base (222f2e1) to head (95f986c).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/flint/fmpz_mat.jl 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2177      +/-   ##
==========================================
- Coverage   88.17%   88.17%   -0.01%     
==========================================
  Files          99       99              
  Lines       37181    37189       +8     
==========================================
+ Hits        32786    32793       +7     
- Misses       4395     4396       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JohnAAbbott JohnAAbbott marked this pull request as ready for review January 15, 2026 14:54
@JohnAAbbott
Copy link
Collaborator Author

Not sure why this was still a draft -- now changed to standard PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant