Refactor dotAccountingAction to use Where class and improve variable naming; update translations in JSON files

Author: Carlos Garcia

Core/Controller/EditSubcuenta.php

@@ -23,6 +23,7 @@
 use FacturaScripts\Core\Lib\ExtendedController\BaseView;
 use FacturaScripts\Core\Lib\ExtendedController\EditController;
 use FacturaScripts\Core\Tools;
+use FacturaScripts\Core\Where;
 use FacturaScripts\Dinamic\Lib\Accounting\Ledger;
 use FacturaScripts\Dinamic\Model\CodeModel;
 use FacturaScripts\Dinamic\Model\Cuenta;
@@ -60,6 +61,7 @@ public function getPageData(): array
     protected function createViews()
     {
         parent::createViews();
+
         $this->setTabsPosition('bottom');
 
         // establecemos el límite de registros a 9999, para el select de cuentas
@@ -245,13 +247,13 @@ protected function prepareSubcuenta(BaseView $view): void
      */
     private function dotAccountingAction(bool $value): bool
     {
-        $ids = $this->request->request->getArray('code');
+        $ids = $this->request->request->getArray('codes');
         if (empty($ids)) {
             Tools::log()->warning('no-selected-item');
-            return false;
+            return true;
         }
 
-        $where = [new DataBaseWhere('idpartida', implode(',', $ids), 'IN')];
+        $where = [Where::in('idpartida', $ids)];
         foreach (Partida::all($where) as $row) {
             $row->setDottedStatus($value);
         }

Core/Lib/ExtendedController/PanelController.php

@@ -113,7 +113,7 @@ public function privateCore(&$response, $user, $permissions)
     }
 
     /**
-     * Sets the tabs position, by default is set to 'left', also supported 'bottom', 'top' and 'left-bottom.
+     * Sets the tabs position, by default is set to 'left', also supported 'bottom', 'top' and 'left-bottom'.
      *
      * @param string $position
      */

Core/Translation/cs_CZ.json

@@ -631,7 +631,7 @@
     "export-bill": "Factura de exportación",
     "extra-file": "Archivo extra",
     "failed": "Selhalo",
-    "fails": "Fallos",
+    "fails": "Chyby",
     "families": "Familias",
     "family": "Familia",
     "family-code": "Código de la família",

Core/Translation/de_DE.json

@@ -631,7 +631,7 @@
     "export-bill": "Exportationsrechnung",
     "extra-file": "Extra Datei",
     "failed": "Fehlgeschlagen",
-    "fails": "Fallos",
+    "fails": "Fehler",
     "families": "Familien",
     "family": "Familie",
     "family-code": "Familiencode",
@@ -1126,7 +1126,7 @@
     "opened": "Geöffnet",
     "opening-acounting-completed": "Buchhaltungseröffnung abgeschlossen",
     "opening-operation": "Öffnung",
-    "operating-system": "Sistema Operativo",
+    "operating-system": "Betriebssystem",
     "operation": "Operation",
     "operation-export": "Betrieb Export",
     "operator": "Bediener",

Core/Translation/pt_BR.json

@@ -584,7 +584,7 @@
     "es-tax-exception-e5": "Espanha: exceção pelo artigo 25 da Lei do IVA",
     "es-tax-exception-e6": "E",
     "es-tax-exception-location-rules": "es-tax-exception-location-rules",
-    "es-tax-exception-passive-subject": "exceção de imposto - sujeito passivo",
+    "es-tax-exception-passive-subject": "Exceção fiscal - sujeito passivo",
     "es-tax-regime-agrarian": "R",
     "es-tax-regime-cash-criteria": "Criterio de caixa",
     "es-tax-regime-especial-agp": "Regime especial da agricultura, pecuária e pesca",