style: reviewer feedback

Co-authored-by: Alan Szepieniec <[email protected]>

Author: Sword-Smith

src/config_models/cli_args.rs

@@ -178,8 +178,8 @@ pub struct Args {
     /// peers into its mempool. And if the node is either upgrading transaction
     /// proofs on the network or composing, it will never merge two transactions
     /// that would exceed this limit. Does not affect block validity, i.e.
-    /// consensus. So a block with more than this number of inputs may be
-    /// considered value. Also does not affect which block proposals that a
+    /// consensus: a block with more than this number of inputs can be
+    /// valid. Also does not affect which block proposals that a
     /// guessing node will attempt to solve the PoW puzzle for. Set to "none" to
     /// disable this limit.
     #[clap(long, value_parser = parse_optional_usize, default_value = "28")]
@@ -630,6 +630,7 @@ mod cli_args_tests {
     #[test]
     fn test_parse_optional_usize() {
         assert_eq!(parse_optional_usize("42"), Ok(Some(42)));
+        assert_eq!(parse_optional_usize("28"), Ok(Some(28)));
         assert_eq!(parse_optional_usize("0"), Ok(Some(0)));
         assert_eq!(parse_optional_usize("none"), Ok(None));
         assert_eq!(parse_optional_usize("None"), Ok(None));

src/main_loop.rs

@@ -806,15 +806,15 @@ impl MainLoopHandler {
                     return Ok(());
                 }
 
-                // Insert into mempool
+                // Insert into mempool, if allowed.
                 if let Err(err) = global_state_mut
                     .mempool_insert(
                         pt2m_transaction.transaction.to_owned(),
                         TransactionOrigin::Foreign,
                     )
                     .await
                 {
-                    warn!("{err}");
+                    warn!("cannot add transaction into mempool: {err}");
                     return Ok(());
                 }
 

src/models/state/mempool.rs

@@ -246,10 +246,10 @@ impl Mempool {
     pub(crate) fn most_dense_single_proof_pair(
         &self,
     ) -> Option<([(&TransactionKernel, &Proof); 2], TransactionOrigin)> {
-        /// Loop from `i`th most valuable transaction in the mempool to the
-        /// least valuable in order to find a pair whose total number of inputs
+        /// Loop from `i`th densest transaction in the mempool to the
+        /// least dense in order to find a pair whose total number of inputs
         /// does not exceed the maximum value.
-        fn skip_first_n_transaction(
+        fn most_dense_pair_skip_first_n(
             mempool: &Mempool,
             i: usize,
         ) -> Option<([(&TransactionKernel, &Proof); 2], TransactionOrigin)> {
@@ -279,7 +279,7 @@ impl Mempool {
             None
         }
 
-        (0..self.len() - 1).find_map(|i| skip_first_n_transaction(self, i))
+        (0..self.len() - 1).find_map(|i| most_dense_pair_skip_first_n(self, i))
     }
 
     /// check if transaction exists in mempool