import fix

NeptuneHub · NeptuneHub · commit af024e6a01d5 · 2026-06-14T10:52:23.000+02:00
diff --git a/app_analysis.py b/app_analysis.py
@@ -33,7 +33,6 @@ def cleaning_page():
             schema:
               type: string
     """
-    from flask import render_template
     return render_template('cleaning.html', title = 'AudioMuse-AI - Database Cleaning', active='cleaning')
 
 @analysis_bp.route('/api/analysis/start', methods=['POST'])
diff --git a/app_clustering.py b/app_clustering.py
@@ -18,8 +18,7 @@
     AI_MODEL_PROVIDER, OLLAMA_SERVER_URL, OLLAMA_MODEL_NAME, OPENAI_SERVER_URL,
     OPENAI_MODEL_NAME, OPENAI_API_KEY, GEMINI_API_KEY, GEMINI_MODEL_NAME,
     TOP_N_PLAYLISTS, MISTRAL_API_KEY, MISTRAL_MODEL_NAME,
-    TASK_STATUS_PENDING, TASK_STATUS_FAILURE, TASK_STATUS_SUCCESS,
-    TASK_STATUS_STARTED, TASK_STATUS_PROGRESS, TASK_STATUS_REVOKED,
+    TASK_STATUS_PENDING, TASK_STATUS_FAILURE,
 )
 
 # RQ import
diff --git a/lyrics/lyrics_transcriber.py b/lyrics/lyrics_transcriber.py
@@ -379,7 +379,6 @@ def _fetch_from_configured_api(
             url,
             headers={'Accept': 'application/json'},
         )
-        import socket
         ctx = None
         try:
             import ssl
diff --git a/rq_worker.py b/rq_worker.py
@@ -30,7 +30,6 @@
 try:
     from app_helper import redis_conn
     from app_logging import configure_logging
-    import config
     from config import APP_VERSION, TEMP_DIR
 except ImportError as e:
     print(f"Error importing worker dependencies: {e}")
diff --git a/tasks/cleaning.py b/tasks/cleaning.py
@@ -3,7 +3,6 @@
 import time
 import logging
 import uuid
-import traceback
 from collections import defaultdict
 
 # RQ import
diff --git a/tasks/clustering.py b/tasks/clustering.py
@@ -27,7 +27,7 @@
     ITERATIONS_PER_BATCH_JOB, MAX_CONCURRENT_BATCH_JOBS,
     MIN_PLAYLIST_SIZE_FOR_TOP_N, CLUSTERING_BATCH_TIMEOUT_MINUTES,
     CLUSTERING_MAX_FAILED_BATCHES, CLUSTERING_CLEANING,
-    TASK_STATUS_PENDING, TASK_STATUS_STARTED, TASK_STATUS_PROGRESS,
+    TASK_STATUS_STARTED, TASK_STATUS_PROGRESS,
     TASK_STATUS_SUCCESS, TASK_STATUS_FAILURE, TASK_STATUS_REVOKED,
 )
 
diff --git a/tasks/voyager_manager.py b/tasks/voyager_manager.py
@@ -1037,7 +1037,7 @@ def find_nearest_neighbors_by_vector(query_vector: np.ndarray, n: int = 100, eli
     if voyager_index is None or id_map is None:
         raise RuntimeError("Voyager index is not loaded in memory.")
 
-    from app_helper import get_db, get_score_data_by_ids
+    from app_helper import get_db
     db_conn = get_db()
 
     # If caller didn't supply eliminate_duplicates explicitly (None), use configured default
diff --git a/test/integration/test.py b/test/integration/test.py
@@ -255,8 +255,6 @@ def test_map_visualization():
     elapsed = time.time() - start_time
     print(f"[TIMING] Map Visualization test completed in {elapsed:.2f} seconds")
 
-import pytest
-
 #pytest -v -s test.py -k test_annoy_similarity_and_playlist
 def test_annoy_similarity_and_playlist():
     start_time = time.time()
diff --git a/test/integration/test_analysis_integration.py b/test/integration/test_analysis_integration.py
@@ -15,7 +15,6 @@
 import sys
 import types
 from pathlib import Path
-import importlib
 import json
 import pytest
 
diff --git a/test/unit/test_ai.py b/test/unit/test_ai.py
@@ -81,7 +81,6 @@ def _ensure_google_genai_stub():
         google_mod.__path__ = []
         sys.modules['google'] = google_mod
     from unittest.mock import MagicMock as _MM
-    from unittest.mock import MagicMock as _MM
     genai_mod = types.ModuleType('google.genai')
     genai_mod.Client = _MM
     genai_types = types.ModuleType('google.genai.types')
@@ -123,7 +122,7 @@ def _ensure_mistralai_stub():
     _load_submodule(_name, _relpath)
 
 
-from unittest.mock import Mock, patch, call
+from unittest.mock import Mock, patch
 import requests
 import json
 from tasks.ai.api import clean_playlist_name, get_ai_playlist_name
diff --git a/test/unit/test_app_analysis.py b/test/unit/test_app_analysis.py
@@ -29,7 +29,7 @@ class TestCleaningPage:
 
     def test_cleaning_page_returns_html(self, client):
         """Test that /cleaning returns HTML content"""
-        with patch('flask.render_template') as mock_render:
+        with patch('app_analysis.render_template') as mock_render:
             mock_render.return_value = "<html>Cleaning Page</html>"
 
             response = client.get('/cleaning')
diff --git a/test/unit/test_app_map_helpers.py b/test/unit/test_app_map_helpers.py
@@ -1,5 +1,3 @@
-import pytest
-
 from app_map import _pick_top_mood, _round_coord, _sample_items
 
 
diff --git a/test/unit/test_error_manager.py b/test/unit/test_error_manager.py
@@ -8,8 +8,6 @@
 import os
 import sys
 
-import pytest
-
 REPO_ROOT = os.path.normpath(
     os.path.join(os.path.dirname(os.path.abspath(__file__)), '..', '..')
 )
diff --git a/test/unit/test_import_smoke.py b/test/unit/test_import_smoke.py
@@ -0,0 +1,74 @@
+"""Smoke test: every project module must import cleanly.
+
+Complements the flake8 F821 (undefined-name) gate. F821 is static and cannot see
+cross-module breakage like ``from x import name_that_no_longer_exists`` or
+``import missing_module`` -- actually importing each module catches those plus
+any other module-load-time error (a moved function leaving a dangling import, a
+typo in a re-export, etc.).
+
+A psycopg2 / redis *connection* error means the import machinery already
+succeeded (the module merely tried to reach a service while loading, e.g.
+``app`` runs ``init_db()`` at import) and is treated as a pass. Genuinely-missing
+optional native deps are skipped; everything else (ImportError, NameError,
+SyntaxError, AttributeError) fails the test.
+"""
+import importlib
+import os
+from pathlib import Path
+
+import psycopg2
+import pytest
+
+REPO_ROOT = Path(__file__).resolve().parents[2]
+
+# Mirrors test_import_architecture._collect_modules excludes (plus scripts/, which
+# are standalone build entry points not meant to import in a server context).
+EXCLUDED_DIRS = {
+    ".git", ".venv", ".venv-windows", "node_modules", "__pycache__",
+    "build", "dist", "pginstall", "native-build", "test", "scripts",
+}
+
+# ImportErrors naming an optional/native dependency that may be absent in CI.
+_OPTIONAL_DEPS = ("cuml", "cupy", "voyager", "faiss", "tensorflow")
+
+
+def _discover_modules():
+    modules = []
+    for dirpath, dirnames, filenames in os.walk(REPO_ROOT):
+        dirnames[:] = [d for d in dirnames if d not in EXCLUDED_DIRS and not d.startswith(".")]
+        for filename in filenames:
+            if not filename.endswith(".py"):
+                continue
+            parts = list((Path(dirpath) / filename).relative_to(REPO_ROOT).parts)
+            if parts[-1] == "__init__.py":
+                parts = parts[:-1]
+            else:
+                parts[-1] = parts[-1][:-3]
+            if parts:
+                modules.append(".".join(parts))
+    return sorted(set(modules))
+
+
+MODULES = _discover_modules()
+
+
+@pytest.mark.parametrize("modname", MODULES)
+def test_module_imports_cleanly(modname):
+    """Importing the module must not raise an ImportError/NameError/etc.
+
+    Reaching a DB/Redis connection during import is fine -- it proves the module
+    loaded; only a real load-time error should fail.
+    """
+    try:
+        importlib.import_module(modname)
+    except psycopg2.OperationalError:
+        pytest.skip(f"{modname}: reached DB connection during import (machinery OK)")
+    except ImportError as exc:
+        msg = str(exc).lower()
+        if any(dep in msg for dep in _OPTIONAL_DEPS):
+            pytest.skip(f"{modname}: optional dependency absent ({exc})")
+        raise
+    except Exception as exc:  # noqa: BLE001 -- surface the real failure
+        if "redis" in type(exc).__module__ and "connect" in str(exc).lower():
+            pytest.skip(f"{modname}: reached Redis connection during import (machinery OK)")
+        raise

Original file line number	Diff line number	Diff line change
`@@ -18,8 +18,7 @@`
`18`	`18`	`AI_MODEL_PROVIDER, OLLAMA_SERVER_URL, OLLAMA_MODEL_NAME, OPENAI_SERVER_URL,`
`19`	`19`	`OPENAI_MODEL_NAME, OPENAI_API_KEY, GEMINI_API_KEY, GEMINI_MODEL_NAME,`
`20`	`20`	`TOP_N_PLAYLISTS, MISTRAL_API_KEY, MISTRAL_MODEL_NAME,`
`21`		`- TASK_STATUS_PENDING, TASK_STATUS_FAILURE, TASK_STATUS_SUCCESS,`
`22`		`- TASK_STATUS_STARTED, TASK_STATUS_PROGRESS, TASK_STATUS_REVOKED,`
	`21`	`+ TASK_STATUS_PENDING, TASK_STATUS_FAILURE,`
`23`	`22`	`)`
`24`	`23`
`25`	`24`	`# RQ import`
Original file line number	Diff line number	Diff line change
`@@ -379,7 +379,6 @@ def _fetch_from_configured_api(`
`379`	`379`	`url,`
`380`	`380`	`headers={'Accept': 'application/json'},`
`381`	`381`	`)`
`382`		`- import socket`
`383`	`382`	`ctx = None`
`384`	`383`	`try:`
`385`	`384`	`import ssl`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@`
`27`	`27`	`ITERATIONS_PER_BATCH_JOB, MAX_CONCURRENT_BATCH_JOBS,`
`28`	`28`	`MIN_PLAYLIST_SIZE_FOR_TOP_N, CLUSTERING_BATCH_TIMEOUT_MINUTES,`
`29`	`29`	`CLUSTERING_MAX_FAILED_BATCHES, CLUSTERING_CLEANING,`
`30`		`- TASK_STATUS_PENDING, TASK_STATUS_STARTED, TASK_STATUS_PROGRESS,`
	`30`	`+ TASK_STATUS_STARTED, TASK_STATUS_PROGRESS,`
`31`	`31`	`TASK_STATUS_SUCCESS, TASK_STATUS_FAILURE, TASK_STATUS_REVOKED,`
`32`	`32`	`)`
`33`	`33`