update skipRecoveryQueue clone logic

Fall back to the source volume's skipRecoveryQueue setting when not explicitly set on the clone.

Author: jharrod

core/concurrent_core.go

@@ -2417,7 +2417,11 @@ func (o *ConcurrentTridentOrchestrator) cloneVolume(
 	cloneConfig.ReadOnlyClone = volConfig.ReadOnlyClone
 	cloneConfig.Namespace = volConfig.Namespace
 	cloneConfig.RequestName = volConfig.RequestName
-	cloneConfig.SkipRecoveryQueue = volConfig.SkipRecoveryQueue
+
+	// If skipRecoveryQueue is set for the clone, use it. If not, default to the source volume's setting.
+	if volConfig.SkipRecoveryQueue != "" {
+		cloneConfig.SkipRecoveryQueue = volConfig.SkipRecoveryQueue
+	}
 
 	// If it's from snapshot, we need the LUKS passphrases value from the snapshot
 	isLUKS, err := strconv.ParseBool(cloneConfig.LUKSEncryption)

core/orchestrator_core.go

@@ -2474,7 +2474,12 @@ func (o *TridentOrchestrator) cloneVolumeInitial(
 	cloneConfig.ReadOnlyClone = volumeConfig.ReadOnlyClone
 	cloneConfig.Namespace = volumeConfig.Namespace
 	cloneConfig.RequestName = volumeConfig.RequestName
-	cloneConfig.SkipRecoveryQueue = volumeConfig.SkipRecoveryQueue
+
+	// If skipRecoveryQueue is set for the clone, use it. If not, default to the source volume's setting.
+	if volumeConfig.SkipRecoveryQueue != "" {
+		cloneConfig.SkipRecoveryQueue = volumeConfig.SkipRecoveryQueue
+	}
+
 	// Empty out the export policy. It will be set in the backend driver.
 	cloneConfig.ExportPolicy = ""