Skip to content

Commit 6fb176d

Browse files
committed
Lock build-deps (again)
1 parent d00048b commit 6fb176d

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

CMakeLists.txt

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
cmake_minimum_required(VERSION 3.28)
2-
file(STRINGS "version.txt" NLE_VERSION)
2+
set(NLE_VERSION 1.2.0)
33
# Remove any rcXX suffix from the version number as CMake doesn't like it
44
string(REGEX REPLACE "rc[0-9+]$" "" CMAKE_NLE_VERSION ${NLE_VERSION})
55
project(nle VERSION ${CMAKE_NLE_VERSION})
@@ -36,13 +36,6 @@ message(STATUS "Building nle backend version: ${CMAKE_NLE_VERSION}")
3636

3737
set(CMAKE_POSITION_INDEPENDENT_CODE ON)
3838

39-
# We use this to decide where the root of the nle/ package is. Normally it
40-
# shouldn't be needed, but sometimes (e.g. when using setuptools) we are
41-
# generating some of the files outside of the original package path.
42-
set(PYTHON_SRC_PARENT
43-
${nle_SOURCE_DIR}
44-
CACHE STRING "Directory containing the nle package files")
45-
4639
set(HACKDIR
4740
"$ENV{HOME}/nethackdir.nle"
4841
CACHE STRING "Configuration files for nethack")

pyproject.toml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,14 +30,15 @@ Homepage = "https://github.com/NetHack-LE/nle"
3030

3131

3232
[build-system]
33-
requires = ["scikit-build-core>=0.10", "pybind11>=2.2", "setuptools-scm"]
33+
# Lock build-deps as uv does not yet support locking of build deps: astral-sh/uv#5190
34+
requires = ["scikit-build-core~=0.10", "pybind11~=2.2", "setuptools-scm~=9.2.2"]
3435
build-backend = "scikit_build_core.build"
3536

3637
[tool.scikit-build]
3738
cmake.build-type = "Release"
39+
cmake.args = ["-DHACKDIR=nle/nethackdir", "-DPYTHON_PACKAGE_NAME=nle"]
3840
minimum-version = "build-system.requires"
3941
wheel.license-files = []
40-
cmake.args = ["-DHACKDIR=nle/nethackdir", "-DPYTHON_PACKAGE_NAME=nle"]
4142

4243
[tool.scikit-build.metadata.version]
4344
provider = "scikit_build_core.metadata.setuptools_scm"

0 commit comments

Comments
 (0)