Merge pull request #41 from Netflix-Skunkworks/fix-return-ordering

return package versions in ascending chronological order

Author: meridional

README.md

@@ -10,7 +10,7 @@ Running the binary & tests requires standing up postgres:
 ```sh
 export POSTGRES_USERNAME=postgres
 export POSTGRES_PASSWORD=postgres
-export POSTGRES_HOST=0.0.0.0
+export POSTGRES_HOST=127.0.0.1
 export POSTGRES_PORT=55432 # In case 5432 is in use already.
 export POSTGRES_DB=index
 docker run \

internal/db/db.go

@@ -52,7 +52,7 @@ func (d *DB) FetchRepoTags(ctx context.Context, since time.Time, limit int64) ([
 SELECT org_repo_name, tag_name, module_path, created
 FROM repo_tags
 WHERE created >= $1
-ORDER BY created DESC
+ORDER BY created ASC
 LIMIT $2;`
 
 	rows, err := d.db.QueryContext(ctx, query, since, limit)

internal/db/db_test.go

@@ -16,10 +16,10 @@ func TestFetchRepoTags(t *testing.T) {
 	resetTables(t, sqlDB)
 
 	allTags := []*db.RepoTag{
-		// Ordered by Created DESC, which is how we expect it returned.
-		{OrgRepoName: "foo/gaz", TagName: "v0.0.1", ModulePath: "github.somecompany.net/foo/gaz", Created: time.Now().Add(time.Minute)},
-		{OrgRepoName: "foo/bar", TagName: "v0.0.2", ModulePath: "github.somecompany.net/foo/bar", Created: time.Now().Add(time.Second)},
+		// Ordered by Created ASC (ascending chronological order), which is how we expect it returned.
 		{OrgRepoName: "foo/bar", TagName: "v0.0.1", ModulePath: "github.somecompany.net/foo/bar", Created: time.Now()},
+		{OrgRepoName: "foo/bar", TagName: "v0.0.2", ModulePath: "github.somecompany.net/foo/bar", Created: time.Now().Add(time.Second)},
+		{OrgRepoName: "foo/gaz", TagName: "v0.0.1", ModulePath: "github.somecompany.net/foo/gaz", Created: time.Now().Add(time.Minute)},
 	}
 	populateRepoTags(t, sqlDB, allTags)
 
@@ -46,7 +46,7 @@ func TestFetchRepoTags(t *testing.T) {
 	if err != nil {
 		t.Fatal(err)
 	}
-	if diff := cmp.Diff(allTags[:1], gotTags, cmpopts.EquateApproxTime(time.Second)); diff != "" {
+	if diff := cmp.Diff(allTags[2:], gotTags, cmpopts.EquateApproxTime(time.Second)); diff != "" {
 		t.Errorf("FetchRepoTags: -want,+got: %s", diff)
 	}
 }