Skip to content

Commit 558d7ab

Browse files
committed
Migrate to use new S3 SDK.
1 parent 54a8dde commit 558d7ab

4 files changed

Lines changed: 19 additions & 23 deletions

File tree

priam/src/main/java/com/netflix/priam/aws/S3FileSystem.java

Lines changed: 17 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -17,35 +17,20 @@
1717
package com.netflix.priam.aws;
1818

1919
import com.google.common.base.Preconditions;
20+
import com.netflix.priam.aws.auth.IS3Credential;
2021
import com.netflix.priam.backup.AbstractBackupPath;
2122
import com.netflix.priam.backup.BackupRestoreException;
2223
import com.netflix.priam.backup.DynamicRateLimiter;
2324
import com.netflix.priam.backup.RangeReadInputStream;
2425
import com.netflix.priam.compress.ChunkedStream;
2526
import com.netflix.priam.compress.CompressionType;
26-
import com.netflix.priam.aws.auth.IS3Credential;
2727
import com.netflix.priam.compress.ICompression;
2828
import com.netflix.priam.config.IConfiguration;
2929
import com.netflix.priam.identity.config.InstanceInfo;
3030
import com.netflix.priam.merics.BackupMetrics;
3131
import com.netflix.priam.notification.BackupNotificationMgr;
3232
import com.netflix.priam.utils.BoundedExponentialRetryCallable;
3333
import com.netflix.priam.utils.SystemUtils;
34-
import java.io.*;
35-
import java.nio.file.Path;
36-
import java.nio.file.Paths;
37-
import java.time.Instant;
38-
import java.util.ArrayList;
39-
import java.util.Collections;
40-
import java.util.HashMap;
41-
import java.util.Iterator;
42-
import java.util.List;
43-
import java.util.Map;
44-
import java.util.concurrent.atomic.AtomicInteger;
45-
import javax.inject.Inject;
46-
import javax.inject.Named;
47-
import javax.inject.Provider;
48-
import javax.inject.Singleton;
4934
import org.apache.commons.io.IOUtils;
5035
import org.slf4j.Logger;
5136
import org.slf4j.LoggerFactory;
@@ -54,6 +39,17 @@
5439
import software.amazon.awssdk.services.s3.S3Client;
5540
import software.amazon.awssdk.services.s3.model.*;
5641

42+
import javax.inject.Inject;
43+
import javax.inject.Named;
44+
import javax.inject.Provider;
45+
import javax.inject.Singleton;
46+
import java.io.*;
47+
import java.nio.file.Path;
48+
import java.nio.file.Paths;
49+
import java.time.Instant;
50+
import java.util.*;
51+
import java.util.concurrent.atomic.AtomicInteger;
52+
5753
/** Implementation of IBackupFileSystem for S3 */
5854
@Singleton
5955
public class S3FileSystem extends S3FileSystemBase {
@@ -109,11 +105,13 @@ protected void downloadFileImpl(AbstractBackupPath path, String suffix)
109105

110106
@Override
111107
public void putObject(String bucket, String key, String value) {
112-
s3Client.putObject(bucket, key, value);
108+
s3Client.putObject(
109+
PutObjectRequest.builder().bucket(bucket).key(key).build(),
110+
RequestBody.fromBytes(value.getBytes()));
113111
}
114112

115-
private ObjectMetadata getObjectMetadata(File file) {
116-
ObjectMetadata ret = new ObjectMetadata();
113+
private Map<String, String> getFileMetadata(File file) {
114+
Map<String, String> metadata = new HashMap<>();
117115
long lastModified = file.lastModified();
118116
long fileSize = file.length();
119117

priam/src/main/java/com/netflix/priam/backupv2/SnapshotVerificationMarkerWriter.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,7 @@
11
package com.netflix.priam.backupv2;
22

3-
import com.amazonaws.services.s3.model.PutObjectResult;
43
import com.netflix.priam.aws.RemoteBackupPath;
54
import com.netflix.priam.backup.AbstractBackupPath;
6-
import com.netflix.priam.backup.BackupRestoreException;
75
import com.netflix.priam.backup.IBackupFileSystem;
86
import com.netflix.priam.config.IConfiguration;
97
import com.netflix.priam.identity.config.InstanceInfo;

priam/src/test/java/com/netflix/priam/backupv2/TestBackupVerificationTask.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ private static BackupMetadata getRecentlyValidatedMetadata() {
188188
BackupMetadata backupMetadata = new BackupMetadata("12345", new Date());
189189
backupMetadata.setLastValidated(
190190
new Date(Instant.now().plus(1, ChronoUnit.HOURS).toEpochMilli()));
191-
backupMetadata.setSnapshotLocation("bucket/path/to/file.db");
191+
backupMetadata.setSnapshotLocation("useast1-cass-test-1/test_backup/-1002_cass_compromised_credentials/-3074457343809683002/META_V2/1762448400000/SNAPPY/PLAINTEXT/meta_v2_202511061700.json");
192192
return backupMetadata;
193193
}
194194
}

priam/src/test/java/com/netflix/priam/resources/BackupServletV2Test.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,7 @@ private static BackupVerificationResult getBackupVerificationResult() {
264264
BackupVerificationResult result = new BackupVerificationResult();
265265
result.valid = true;
266266
result.manifestAvailable = true;
267-
result.remotePath = "some_random";
267+
result.remotePath = "test_backup/-1002_cass_compromised_credentials/-3074457343809683002/META_V2/1762448400000/SNAPPY/PLAINTEXT/meta_v2_202511061700.json";
268268
result.filesMatched = 123;
269269
result.snapshotInstant = Instant.EPOCH;
270270
return result;

0 commit comments

Comments
 (0)