Skip to content

Commit b48b124

Browse files
Merge pull request #755 from Netflix/jdk17
update infra to use JDK 17
2 parents 579ef15 + d2797b7 commit b48b124

File tree

6 files changed

+13
-12
lines changed

6 files changed

+13
-12
lines changed

.github/workflows/nebula-publish.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
uses: actions/setup-java@v4
1818
with:
1919
distribution: 'zulu'
20-
java-version: 8
20+
java-version: 17
2121
- uses: actions/[email protected]
2222
id: gradle-cache
2323
with:

.github/workflows/nebula-snapshot.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ jobs:
1717
- name: Set up JDK
1818
uses: actions/setup-java@v4
1919
with:
20-
java-version: 8
20+
java-version: 17
2121
distribution: zulu
2222
- uses: actions/[email protected]
2323
id: gradle-cache

.github/workflows/update-gradle-wrapper.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,6 @@ jobs:
1515
uses: actions/setup-java@v4
1616
with:
1717
distribution: 'zulu'
18-
java-version: 8
18+
java-version: 17
1919
- name: Update Gradle Wrapper
2020
uses: gradle-update/update-gradle-wrapper-action@v2

.sdkmanrc

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
# Enable auto-env through the sdkman_auto_env config
22
# Add key=value pairs of SDKs to use below
3-
java=8.0.312-zulu
3+
java=17.0.11-zulu

CONTRIBUTING.md

+8-7
Original file line numberDiff line numberDiff line change
@@ -82,17 +82,18 @@ Working on the code base
8282

8383
IDE setup
8484
-----
85-
The DGS codebases are Kotlin based. We strongly recommend using Intellij because of the excellent support for Kotlin and
86-
Gradle. You can use the free [Intellij Community Edition](https://www.jetbrains.com/idea/download/).
85+
The DGS codebases are Kotlin based.
86+
We strongly recommend using IntelliJ because of the excellent support for Kotlin and Gradle.
87+
You can use the free [IntelliJ Community Edition](https://www.jetbrains.com/idea/download/).
8788

88-
Clone and open the project using the "project from version control feature" and let Gradle import all dependencies. Note
89-
that we build on Java 8, so a Java 8 JDK is required. If you don't have a JDK, you can use [sdkman](https://sdkman.io/)
90-
or [Intellij](https://www.jetbrains.com/help/idea/sdk.html) to install one. Because almost all the code is Kotlin, we
91-
don't miss any language features of newer Java releases while supporting a broad range of older releases.
89+
Clone and open the project using the "project from version control feature" and let Gradle import all dependencies.
90+
Note that we build on Java 17, so a Java 17 JDK is required.
91+
If you don't have a JDK, you can use [sdkman](https://sdkman.io/) or [IntelliJ](https://www.jetbrains.com/help/idea/sdk.html) to install one.
92+
Because almost all the code is Kotlin, we don't miss any language features of newer Java releases while supporting a broad range of older releases.
9293

9394
Code conventions
9495
-----
95-
We use the standard Kotlin coding conventions. Intellij should select the correct style automatically because we checked
96+
We use the standard Kotlin coding conventions. IntelliJ should select the correct style automatically because we checked
9697
in the `.idea/codeStyle` folder. Furthermore, we're also using [Ktlint](https://ktlint.github.io/). You can run
9798
formatting manually using Gradle:
9899

graphql-dgs-codegen-core/Dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
FROM dockerregistry.test.netflix.net:7002/platform/java/8:latest
1+
FROM dockerregistry.test.netflix.net:7002/platform/java/17:latest
22

33
COPY build/distributions/*.tar /app/
44

0 commit comments

Comments
 (0)