Skip to content

Commit f890f36

Browse files
Revert "Merge pull request #564 from Sineaggi/add-support-for-configuration-cache"
This reverts commit e5185ac, reversing changes made to 127a6d2.
1 parent e5185ac commit f890f36

File tree

5 files changed

+5
-236
lines changed

5 files changed

+5
-236
lines changed

graphql-dgs-codegen-gradle/src/main/kotlin/com/netflix/graphql/dgs/codegen/gradle/CodegenPlugin.kt

+2-16
Original file line numberDiff line numberDiff line change
@@ -51,22 +51,8 @@ class CodegenPlugin : Plugin<Project> {
5151
val outputDir = generateJavaTaskProvider.map(GenerateJavaTask::getOutputDir)
5252
mainSourceSet.java.srcDirs(project.files(outputDir).builtBy(generateJavaTaskProvider))
5353

54-
val dgsCodegen = project.configurations.create("dgsCodegen")
55-
dgsCodegen.isCanBeResolved = true
56-
generateJavaTaskProvider.configure {
57-
it.dependencies.addAll(
58-
dgsCodegen.incoming.dependencies.map { dependency ->
59-
InternalSimpleDependency(dependency.name, dependency.group)
60-
}
61-
)
62-
if (GradleVersion.current() >= GradleVersion.version("7.4")) {
63-
it.schemaJarArtifacts.addAll(dgsCodegen.incoming.artifacts.resolvedArtifacts.map { it.map { it.id } })
64-
it.schemaJarFiles.addAll(dgsCodegen.incoming.artifacts.resolvedArtifacts.map { it.map { it.file } })
65-
} else {
66-
it.schemaJarArtifacts.addAll(project.provider { dgsCodegen.incoming.artifacts.artifacts.map { it.id } })
67-
it.schemaJarFiles.addAll(project.provider { dgsCodegen.incoming.artifacts.artifacts.map { it.file } })
68-
}
69-
}
54+
project.configurations.create("dgsCodegen")
55+
project.configurations.findByName("dgsCodegen")?.isCanBeResolved = true
7056

7157
project.afterEvaluate { p ->
7258
if (extensions.clientCoreConventionsEnabled.getOrElse(true)) {

graphql-dgs-codegen-gradle/src/main/kotlin/com/netflix/graphql/dgs/codegen/gradle/GenerateJavaTask.kt

+3-14
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ import com.netflix.graphql.dgs.codegen.CodeGen
2222
import com.netflix.graphql.dgs.codegen.CodeGenConfig
2323
import com.netflix.graphql.dgs.codegen.Language
2424
import org.gradle.api.DefaultTask
25-
import org.gradle.api.artifacts.component.ComponentArtifactIdentifier
2625
import org.gradle.api.tasks.*
2726
import org.jetbrains.kotlin.gradle.plugin.KotlinPluginWrapper
2827
import java.io.File
@@ -149,23 +148,13 @@ open class GenerateJavaTask : DefaultTask() {
149148
@Input
150149
var includeClassImports = mutableMapOf<String, MutableMap<String, String>>()
151150

152-
@Input
153-
val dependencies = project.objects.setProperty(InternalSimpleDependency::class.java)
154-
155-
@Input
156-
val schemaJarArtifacts = project.objects.listProperty(ComponentArtifactIdentifier::class.java)
157-
158-
@InputFiles
159-
val schemaJarFiles = project.objects.listProperty(File::class.java)
160-
161151
@TaskAction
162152
fun generate() {
163153
val schemaJarFilesFromDependencies = emptyList<File>().toMutableList()
164-
dependencies.get().forEach { dependency ->
154+
val dgsCodegenConfig = project.configurations.findByName("dgsCodegen")
155+
dgsCodegenConfig?.incoming?.dependencies?.forEach { dependency ->
165156
logger.info("Found DgsCodegen Dependendency: ${dependency.name}")
166-
data class InternalArtifactResult(val id: ComponentArtifactIdentifier, val file: File)
167-
val resolvedArtifacts = schemaJarArtifacts.get().zip(schemaJarFiles.get()) { id, file -> InternalArtifactResult(id, file) }
168-
val found = resolvedArtifacts.find { it.id.componentIdentifier.displayName.contains(dependency.group + ":" + dependency.name) }
157+
val found = dgsCodegenConfig.incoming.artifacts.resolvedArtifacts.get().find { it.id.componentIdentifier.displayName.contains(dependency.group + ":" + dependency.name) }
169158
if (found != null) {
170159
logger.info("Found DgsCodegen Artifact: ${found.id.displayName}")
171160
schemaJarFilesFromDependencies.add(found.file)

graphql-dgs-codegen-gradle/src/main/kotlin/com/netflix/graphql/dgs/codegen/gradle/InternalSimpleDependency.kt

-23
This file was deleted.

graphql-dgs-codegen-gradle/src/test/kotlin/com/netflix/graphql/dgs/CodegenGradlePluginCompatibilityTest.kt

-20
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ package com.netflix.graphql.dgs
2323
import org.assertj.core.api.Assertions.assertThat
2424
import org.gradle.testkit.runner.GradleRunner
2525
import org.gradle.testkit.runner.TaskOutcome.SUCCESS
26-
import org.gradle.testkit.runner.TaskOutcome.UP_TO_DATE
2726
import org.junit.jupiter.api.io.TempDir
2827
import org.junit.jupiter.params.ParameterizedTest
2928
import org.junit.jupiter.params.provider.ValueSource
@@ -107,7 +106,6 @@ class CodegenGradlePluginCompatibilityTest {
107106
.withPluginClasspath()
108107
.withDebug(true)
109108
.withArguments(
110-
"--configuration-cache",
111109
"--stacktrace",
112110
"--info",
113111
"generateJava",
@@ -116,24 +114,6 @@ class CodegenGradlePluginCompatibilityTest {
116114

117115
assertThat(result.task(":generateJava")).extracting { it?.outcome }.isEqualTo(SUCCESS)
118116
assertThat(result.task(":build")).extracting { it?.outcome }.isEqualTo(SUCCESS)
119-
assertThat(result.output).contains("Configuration cache entry stored.")
120-
121-
val rerunResult = GradleRunner.create()
122-
.withGradleVersion(gradleVersion)
123-
.withProjectDir(projectDir)
124-
.withPluginClasspath()
125-
.withDebug(true)
126-
.withArguments(
127-
"--configuration-cache",
128-
"--stacktrace",
129-
"--info",
130-
"generateJava",
131-
"build"
132-
).build()
133-
134-
assertThat(rerunResult.task(":generateJava")).extracting { it?.outcome }.isEqualTo(UP_TO_DATE)
135-
assertThat(rerunResult.task(":build")).extracting { it?.outcome }.isEqualTo(UP_TO_DATE)
136-
assertThat(rerunResult.output).contains("Configuration cache entry reused.")
137117
}
138118

139119
private fun prepareBuildGradleFile(content: String) {

graphql-dgs-codegen-gradle/src/test/kotlin/com/netflix/graphql/dgs/CodegenGradlePluginConfigurationCacheTest.kt

-163
This file was deleted.

0 commit comments

Comments
 (0)