Skip to content
This repository was archived by the owner on Sep 3, 2025. It is now read-only.

Commit b897d35

Browse files
committed
correcting typo and return value
1 parent 843ce59 commit b897d35

File tree

2 files changed

+18
-13
lines changed

2 files changed

+18
-13
lines changed

src/dispatch/canvas/flows.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ def _create_case_participants_canvas(case: Case, db_session: Session) -> Optiona
147147
title="Participants",
148148
user_emails=(
149149
[case.assignee.individual.email] if case.assignee else []
150-
), # Give assginee edit permissions
150+
), # Give assignee edit permissions
151151
content=table_content,
152152
)
153153

src/dispatch/plugins/dispatch_slack/service.py

Lines changed: 17 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -804,22 +804,27 @@ def canvas_set_access(
804804
Returns:
805805
bool: True if the canvas was successfully updated, False otherwise.
806806
"""
807-
response = make_call(
808-
client,
809-
SlackAPIPostEndpoints.canvas_access_set,
810-
access_level="read",
811-
canvas_id=canvas_id,
812-
channel_ids=[conversation_id],
813-
)
814-
if user_ids:
815-
response = response and make_call(
807+
try:
808+
make_call(
816809
client,
817810
SlackAPIPostEndpoints.canvas_access_set,
818-
access_level="write",
811+
access_level="read",
819812
canvas_id=canvas_id,
820-
user_ids=user_ids,
813+
channel_ids=[conversation_id],
821814
)
822-
return response
815+
if user_ids:
816+
make_call(
817+
client,
818+
SlackAPIPostEndpoints.canvas_access_set,
819+
access_level="write",
820+
canvas_id=canvas_id,
821+
user_ids=user_ids,
822+
)
823+
824+
return True
825+
except SlackApiError as e:
826+
log.exception(f"Error setting canvas access for canvas {canvas_id}: {e}")
827+
return False
823828

824829

825830
def create_canvas(

0 commit comments

Comments
 (0)