remove debug

Author: Alicia Matsumoto

src/dispatch/auth/permissions.py

@@ -335,37 +335,45 @@ def has_required_permissions(
             request=request,
         )
 
+
 class IncidentEditPermissionForTasks(BasePermission):
     """
     Permissions dependency to apply incident edit permissions to task-based requests.
     """
+
     def has_required_permissions(self, request: Request) -> bool:
         incident_id = None
         # for task creation, retrieve the incident id from the payload
-        if request.method == 'POST' and hasattr(request, '_body'):
+        if request.method == "POST" and hasattr(request, "_body"):
             try:
                 import json
+
                 body = json.loads(request._body.decode())
-                incident_id = body['incident']['id']
+                incident_id = body["incident"]["id"]
             except (json.JSONDecodeError, KeyError, AttributeError):
-                log.error("Encountered create_task request without expected incident ID. Cannot properly ascertain incident permissions.")
+                log.error(
+                    "Encountered create_task request without expected incident ID. Cannot properly ascertain incident permissions."
+                )
                 return False
-        else: # otherwise, retrieve via the task id
+        else:  # otherwise, retrieve via the task id
             pk = PrimaryKeyModel(id=request.path_params["task_id"])
             current_task = task_service.get(db_session=request.state.db, task_id=pk.id)
             if not current_task or not current_task.incident:
                 return False
             incident_id = current_task.incident.id
 
-        print(incident_id)
         # minimal object with the attributes required for IncidentViewPermission
-        incident_request = type('IncidentRequest', (), {
-            'path_params': {**request.path_params, 'incident_id': incident_id},
-            'state': request.state
-        })()
+        incident_request = type(
+            "IncidentRequest",
+            (),
+            {
+                "path_params": {**request.path_params, "incident_id": incident_id},
+                "state": request.state,
+            },
+        )()
 
         # copy necessary request attributes
-        for attr in ['headers', 'method', 'url', 'query_params']:
+        for attr in ["headers", "method", "url", "query_params"]:
             if hasattr(request, attr):
                 setattr(incident_request, attr, getattr(request, attr))
 

src/dispatch/task/views.py

@@ -3,10 +3,7 @@
 
 
 from dispatch.auth.service import CurrentUser
-from dispatch.auth.permissions import (
-    PermissionsDependency,
-    IncidentEditPermissionForTasks
-)
+from dispatch.auth.permissions import PermissionsDependency, IncidentEditPermissionForTasks
 from dispatch.common.utils.views import create_pydantic_include
 from dispatch.database.core import DbSession
 from dispatch.database.service import CommonParameters, search_filter_sort_paginate
@@ -47,7 +44,12 @@ def get_tasks(common: CommonParameters, include: list[str] = Query([], alias="in
     return json.loads(TaskPagination(**pagination).json())
 
 
-@router.post("", response_model=TaskRead, tags=["tasks"], dependencies=[Depends(PermissionsDependency([IncidentEditPermissionForTasks]))])
+@router.post(
+    "",
+    response_model=TaskRead,
+    tags=["tasks"],
+    dependencies=[Depends(PermissionsDependency([IncidentEditPermissionForTasks]))],
+)
 def create_task(
     db_session: DbSession,
     task_in: TaskCreate,
@@ -68,12 +70,12 @@ def create_task(
     return task
 
 
-@router.post("/ticket/{task_id}", tags=["tasks"], dependencies=[Depends(PermissionsDependency([IncidentEditPermissionForTasks]))])
-def create_ticket(
-    db_session: DbSession,
-    task_id: PrimaryKey,
-    current_user: CurrentUser
-):
+@router.post(
+    "/ticket/{task_id}",
+    tags=["tasks"],
+    dependencies=[Depends(PermissionsDependency([IncidentEditPermissionForTasks]))],
+)
+def create_ticket(db_session: DbSession, task_id: PrimaryKey, current_user: CurrentUser):
     """Creates a ticket for an existing task."""
     task = get(db_session=db_session, task_id=task_id)
     if not task:
@@ -84,8 +86,15 @@ def create_ticket(
     return create_task_ticket(task=task, db_session=db_session)
 
 
-@router.put("/{task_id}", response_model=TaskRead, tags=["tasks"], dependencies=[Depends(PermissionsDependency([IncidentEditPermissionForTasks]))])
-def update_task(db_session: DbSession, task_id: PrimaryKey, task_in: TaskUpdate, current_user: CurrentUser):
+@router.put(
+    "/{task_id}",
+    response_model=TaskRead,
+    tags=["tasks"],
+    dependencies=[Depends(PermissionsDependency([IncidentEditPermissionForTasks]))],
+)
+def update_task(
+    db_session: DbSession, task_id: PrimaryKey, task_in: TaskUpdate, current_user: CurrentUser
+):
     """Updates an existing task."""
     task = get(db_session=db_session, task_id=task_id)
     if not task:
@@ -109,7 +118,12 @@ def update_task(db_session: DbSession, task_id: PrimaryKey, task_in: TaskUpdate,
     return task
 
 
-@router.delete("/{task_id}", response_model=None, tags=["tasks"], dependencies=[Depends(PermissionsDependency([IncidentEditPermissionForTasks]))])
+@router.delete(
+    "/{task_id}",
+    response_model=None,
+    tags=["tasks"],
+    dependencies=[Depends(PermissionsDependency([IncidentEditPermissionForTasks]))],
+)
 def delete_task(db_session: DbSession, task_id: PrimaryKey, current_user: CurrentUser):
     """Deletes an existing task."""
     task = get(db_session=db_session, task_id=task_id)