replace slotId tag with clientId (#764)

In pushServer the slotId tag cardinality is too big and we can achieve similar granularity using combination of clientId + infra tags

Author: Andyz26

Diff for: mantis-network/src/main/java/io/reactivex/mantis/network/push/PushServer.java

@@ -245,11 +245,11 @@ protected Observable<Void> manageConnectionWithCompression(final DefaultChannelW
             groupId = id;
         }
 
-        final BasicTag slotIdTag = new BasicTag("slotId", slotId);
+        final BasicTag clientIdTag = new BasicTag(CLIENT_ID_TAG_NAME, Optional.ofNullable(groupId).orElse("none"));
 
         SerializedSubject<List<byte[]>, List<byte[]>> subject
             = new SerializedSubject<>(PublishSubject.<List<byte[]>>create());
-        Observable<List<byte[]>> observable = subject.lift(new DropOperator<>("batch_writes", slotIdTag));
+        Observable<List<byte[]>> observable = subject.lift(new DropOperator<>("batch_writes", clientIdTag));
 
         if (applySampling) {
             observable =
@@ -266,7 +266,6 @@ protected Observable<Void> manageConnectionWithCompression(final DefaultChannelW
                     );
         }
 
-        final BasicTag clientIdTag = new BasicTag(CLIENT_ID_TAG_NAME, Optional.ofNullable(groupId).orElse("none"));
         Metrics writableMetrics = new Metrics.Builder()
             .id("PushServer", clientIdTag)
             .addCounter("channelWritable")