cleanup: remove duplicate import, unused imports, and non-functional mock test

Author: Nissan Pow

metaflow/plugins/aws/step_functions/step_functions_cli.py

@@ -20,7 +20,6 @@
 
 from .production_token import load_token, new_token, store_token
 from .step_functions import StepFunctions
-from metaflow.tagging_util import validate_tags
 from ..aws_utils import validate_aws_tag
 
 VALID_NAME = re.compile(r"[^a-zA-Z0-9_\-\.]")

test/unit/test_tag_improvements.py

@@ -5,9 +5,6 @@
 """
 
 import json
-import os
-import pytest
-from unittest.mock import patch, MagicMock
 
 
 class TestTriggerTimeTags:
@@ -130,34 +127,6 @@ def test_get_origin_run_tags_handles_missing_run(self):
         result = _get_origin_run_tags("NonExistentFlow", "nonexistent_run_id")
         assert result == []
 
-    def test_get_origin_run_tags_with_mock(self):
-        """Test that user_tags from origin run are returned."""
-        from metaflow.cli_components.run_cmds import _get_origin_run_tags
-
-        mock_run = MagicMock()
-        mock_run.user_tags = {"experiment_v2", "batch_1"}
-
-        with patch(
-            "metaflow.cli_components.run_cmds.Run",
-            return_value=mock_run,
-            create=True,
-        ) as mock_cls:
-            # We need to patch where it's imported
-            with patch(
-                "metaflow.client.core.Run",
-                return_value=mock_run,
-            ):
-                # The function does a local import, so we need to patch at module level
-                pass
-
-        # Since the function uses a local import, let's test through the actual
-        # function with a mock at the right level
-        with patch.dict("sys.modules", {}):
-            # This is tricky with local imports. Test the contract instead:
-            # _get_origin_run_tags should return a list
-            result = _get_origin_run_tags("SomeFlow", "some_run_id")
-            assert isinstance(result, list)
-
     def test_resume_tags_merge_logic(self):
         """Verify that origin tags are merged with CLI tags correctly."""
         # Simulates the merge logic in resume()