refactor: consolidate test deps into setup.py [dev]

Move pytest-timeout, pytest-cov, pytest-xdist, pytest-rerunfailures,
and localbatch into setup.py extras_require[dev] so there is a single
source of truth. tox.ini, GHA, and requirements-devstack.txt all just
do 'pip install -e .[dev]' and pick everything up automatically.

Author: Nissan Pow

.github/workflows/ux-tests.yml

@@ -46,7 +46,7 @@ jobs:
       - name: Install Metaflow and test dependencies
         run: |
           pip install --upgrade pip
-          pip install -e ".[dev]" pytest-timeout pytest-cov
+          pip install -e ".[dev]"
 
       - name: Run unit and command tests
         run: |
@@ -138,8 +138,7 @@ jobs:
       - name: Install Metaflow and test dependencies
         run: |
           pip install --upgrade pip
-          pip install -e ".[dev]" pytest-xdist pytest-timeout pytest-cov pytest-rerunfailures
-          pip install "git+https://github.com/npow/localbatch.git@main#egg=localbatch"
+          pip install -e ".[dev]"
 
       - name: Set up minikube
         uses: medyagh/setup-minikube@aba8d5ff1666d19b9549133e3b92e70d4fc52cb7

devtools/requirements-devstack.txt

@@ -1 +1 @@
-localbatch
+-e .[dev]

setup.py

@@ -64,6 +64,15 @@ def find_devtools_files():
     install_requires=["requests", "boto3"],
     extras_require={
         "stubs": ["metaflow-stubs==%s" % version],
-        "dev": ["pytest", "omegaconf", "kubernetes"],
+        "dev": [
+            "pytest",
+            "pytest-timeout",
+            "pytest-cov",
+            "pytest-xdist",
+            "pytest-rerunfailures",
+            "omegaconf",
+            "kubernetes",
+            "localbatch",
+        ],
     },
 )

tox.ini

@@ -8,29 +8,18 @@ commands = ./test_runner
 passenv = *
 deps =
     -e {toxinidir}[dev]
-    pytest-timeout>=2.0
-    pytest-cov>=4.0
 
 [testenv:unit]
 commands = pytest test/unit/ test/cmd/ test/plugins/ --ignore=test/unit/spin -v --tb=short --timeout=120 {posargs}
 
 [testenv:ux-local]
-deps = {[testenv]deps}
-       pytest-xdist>=3.0
 commands = pytest test/ux/core/ --only-backend local -n 4 -v --tb=short --timeout=1800 {posargs}
 
 [testenv:ux-sfn]
-deps = {[testenv]deps}
-       pytest-xdist>=3.0
-       localbatch @ git+https://github.com/npow/localbatch.git@main
 commands = pytest test/ux/core/ --only-backend sfn-batch -n 4 -v --tb=short --timeout=1800 {posargs}
 
 [testenv:ux-argo]
-deps = {[testenv]deps}
-       pytest-xdist>=3.0
 commands = pytest test/ux/core/ --only-backend argo-kubernetes -n 2 -v --tb=short --timeout=1800 {posargs}
 
 [testenv:ux-airflow]
-deps = {[testenv]deps}
-       pytest-xdist>=3.0
 commands = pytest test/ux/core/ --only-backend airflow-kubernetes -n 2 -v --tb=short --timeout=1800 {posargs}