Skip to content

Commit 282c17c

Browse files
committed
fix ui
1 parent ef85131 commit 282c17c

File tree

1 file changed

+17
-4
lines changed

1 file changed

+17
-4
lines changed

devtools/Makefile

+17-4
Original file line numberDiff line numberDiff line change
@@ -285,18 +285,31 @@ create-dev-shell: setup-tilt
285285
echo "🔑 Execute it from ANY directory to switch to development environment shell!" \
286286
'
287287

288-
metaflow-ui: setup-tilt
288+
ui: setup-tilt
289289
@echo "⏳ Checking if the development environment is up..."
290290
@if ! $(TILT) get session >/dev/null 2>&1; then \
291291
echo "❌ Development environment is not up."; \
292-
echo " Please run 'make up' in another terminal, then re-run 'make metaflow-ui'."; \
292+
echo " Please run 'metaflow-dev up' in another terminal, then re-run 'metaflow-dev ui'."; \
293293
exit 1; \
294294
fi
295295
@echo "⏳ Waiting for Metaflow UI to be ready..."
296-
@$(TILT) wait --for=condition=Ready uiresource/metaflow-ui
296+
@while true; do \
297+
"$(TILT)" get uiresource metaflow-ui >/dev/null 2>&1; \
298+
status=$$?; \
299+
if [ $$status -eq 0 ]; then \
300+
"$(TILT)" wait --for=condition=Ready uiresource/metaflow-ui; \
301+
break; \
302+
elif [ $$status -eq 127 ]; then \
303+
echo "❌ Development environment is not up."; \
304+
echo " Please run 'metaflow-dev up' in another terminal, then re-run 'metaflow-dev shell'."; \
305+
exit 1; \
306+
else \
307+
sleep 1; \
308+
fi; \
309+
done
297310
@echo "🔗 Opening Metaflow UI at http://localhost:3000"
298311
@open http://localhost:3000
299312

300-
.PHONY: install-helm setup-minikube setup-tilt teardown-minikube tunnel up down check-docker install-curl install-gum install-brew up down dashboard shell help
313+
.PHONY: install-helm setup-minikube setup-tilt teardown-minikube tunnel up down check-docker install-curl install-gum install-brew up down dashboard shell ui help
301314

302315
.DEFAULT_GOAL := up

0 commit comments

Comments
 (0)