Skip to content

Commit 446e38e

Browse files
Nissan Powclaude
andcommitted
test: remove BATCH_CLIENT_PARAMS xfail, now in core
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent a368b2b commit 446e38e

1 file changed

Lines changed: 2 additions & 12 deletions

File tree

test/unit/localbatch/test_localbatch.py

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -333,13 +333,6 @@ def test_inject_env_is_visible_inside_container(self):
333333
# ---------------------------------------------------------------------------
334334

335335

336-
_NEEDS_CORE_BATCH_PARAMS = pytest.mark.xfail(
337-
reason="requires npow/core-deployer-changes: BATCH_CLIENT_PARAMS must be added "
338-
"to metaflow_config.py so METAFLOW_BATCH_CLIENT_PARAMS env var is recognized",
339-
strict=False,
340-
)
341-
342-
343336
@pytest.mark.docker
344337
class TestMetaflowE2E:
345338
"""
@@ -357,7 +350,6 @@ def _require_docker(self):
357350
except Exception:
358351
pytest.skip("Docker not available")
359352

360-
@_NEEDS_CORE_BATCH_PARAMS
361353
def test_batch_step_artifacts_are_persisted(self, simple_batch_run):
362354
"""
363355
The @batch step writes message='hello from localbatch' and value=42.
@@ -367,11 +359,9 @@ def test_batch_step_artifacts_are_persisted(self, simple_batch_run):
367359
assert task["message"].data == "hello from localbatch"
368360
assert task["value"].data == 42
369361

370-
@_NEEDS_CORE_BATCH_PARAMS
371-
def test_run_succeeds(self, simple_batch_run):
362+
def test_run_succeeds(self, simple_batch_run):
372363
assert simple_batch_run.successful
373364

374-
@_NEEDS_CORE_BATCH_PARAMS
375-
def test_all_steps_have_tasks(self, simple_batch_run):
365+
def test_all_steps_have_tasks(self, simple_batch_run):
376366
step_names = {s.id for s in simple_batch_run.steps()}
377367
assert {"start", "end"} <= step_names

0 commit comments

Comments
 (0)