Skip to content

Commit 5132ee7

Browse files
committed
add guard against empty node_groups
1 parent 3d6f27c commit 5132ee7

1 file changed

Lines changed: 18 additions & 16 deletions

File tree

metaflow/plugins/argo/argo_workflows.py

Lines changed: 18 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1503,23 +1503,25 @@ def build_ancestor_tree(node_groups, switch_ancestors):
15031503
result[parent] = [[g for _, g in chain] for chain in chains]
15041504
return result
15051505

1506-
conditional_deps = []
1507-
required_deps = []
1508-
for parent, chains in build_ancestor_tree(
1509-
node_groups, node_switch_ancestors
1510-
).items():
1511-
parts = []
1512-
for chain in chains:
1513-
groups = [
1514-
"({})".format(
1515-
" || ".join(
1516-
"%s.Succeeded" % self._sanitize(g) for g in grp
1506+
if node_groups:
1507+
conditional_deps = []
1508+
required_deps = []
1509+
for parent, chains in build_ancestor_tree(
1510+
node_groups, node_switch_ancestors
1511+
).items():
1512+
parts = []
1513+
for chain in chains:
1514+
groups = [
1515+
"({})".format(
1516+
" || ".join(
1517+
"%s.Succeeded" % self._sanitize(g)
1518+
for g in grp
1519+
)
15171520
)
1518-
)
1519-
for grp in chain
1520-
]
1521-
parts.append("({})".format(" || ".join(groups)))
1522-
required_deps.append("&&".join(parts))
1521+
for grp in chain
1522+
]
1523+
parts.append("({})".format(" || ".join(groups)))
1524+
required_deps.append("&&".join(parts))
15231525

15241526
both_conditions = required_deps and conditional_deps
15251527

0 commit comments

Comments
 (0)