refactor reserved_params list

Author: saikonen

metaflow/parameters.py

@@ -289,26 +289,8 @@ def __init__(
 
         # TODO: check that the type is one of the supported types
         param_type = self.kwargs["type"] = self._get_type(kwargs)
-        reserved_params = [
-            "params",
-            "with",
-            "max-num-splits",
-            "max_num_splits",
-            "max-workers",
-            "max_workers",
-            "tag",
-            "run-id-file",
-            "run_id_file",
-            "namespace",
-            "obj",
-            "decospecs",
-            "max-log-size",
-            "max_log_size",
-            "tags",
-            "user_namespace",
-        ]
-
-        if self.name in reserved_params:
+
+        if self.name in _reserved_params():
             raise MetaflowException(
                 "Parameter name '%s' is a reserved "
                 "word. Please use a different "
@@ -383,6 +365,28 @@ def __getitem__(self, x):
         pass
 
 
+def _reserved_params():
+    reserved_params = [
+        "params",
+        "with",
+        "tag",
+        "namespace",
+        "obj",
+        "tags",
+        "decospecs",
+        "run-id-file",
+        "max-num-splits",
+        "max-workers",
+        "max-log-size",
+        "user-namespace",
+    ]
+    reserved = set(reserved_params)
+    # due to the way Click maps cli args to function args we also want to add underscored params to the set
+    for param in reserved_params:
+        reserved.add(param.replace("-", "_"))
+    return reserved
+
+
 def add_custom_parameters(deploy_mode=False):
     # deploy_mode determines whether deploy-time functions should or should
     # not be evaluated for this command