Skip to content

Commit cb7e945

Browse files
authored
fix: update list of reserved parameter names (#1736)
* update list of reserved parameter names
1 parent 1bacc31 commit cb7e945

File tree

1 file changed

+14
-4
lines changed

1 file changed

+14
-4
lines changed

metaflow/parameters.py

+14-4
Original file line numberDiff line numberDiff line change
@@ -289,17 +289,27 @@ def __init__(
289289

290290
# TODO: check that the type is one of the supported types
291291
param_type = self.kwargs["type"] = self._get_type(kwargs)
292+
292293
reserved_params = [
293294
"params",
294295
"with",
295-
"max-num-splits",
296-
"max-workers",
297296
"tag",
298-
"run-id-file",
299297
"namespace",
298+
"obj",
299+
"tags",
300+
"decospecs",
301+
"run-id-file",
302+
"max-num-splits",
303+
"max-workers",
304+
"max-log-size",
305+
"user-namespace",
300306
]
307+
reserved = set(reserved_params)
308+
# due to the way Click maps cli args to function args we also want to add underscored params to the set
309+
for param in reserved_params:
310+
reserved.add(param.replace("-", "_"))
301311

302-
if self.name in reserved_params:
312+
if self.name in reserved:
303313
raise MetaflowException(
304314
"Parameter name '%s' is a reserved "
305315
"word. Please use a different "

0 commit comments

Comments
 (0)