Skip to content

Commit f540869

Browse files
author
Nissan Pow
committed
chore: use vanilla python:3.9 image instead of custom metaflow-test image
Metaflow's code packaging bootstraps boto3/requests (and micromamba for @conda/@pypi) at runtime, so tests don't need a pre-baked image. - Remove devtools/docker/metaflow-test/Dockerfile - Remove build-test-image Tilt resource - Switch all backends to python:3.9 (drop image_pull_policy=Never) - Remove CI step waiting for the test image to load
1 parent d655ec5 commit f540869

4 files changed

Lines changed: 3 additions & 32 deletions

File tree

.github/workflows/ux-tests.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -214,11 +214,6 @@ jobs:
214214
env:
215215
SERVICES: ${{ matrix.services }}
216216

217-
- name: Wait for test image to be loaded into minikube
218-
if: matrix.backend != 'local' && matrix.backend != 'sfn-batch'
219-
run: |
220-
tilt wait --for=condition=Ready uiresource/build-test-image --timeout=300s
221-
222217
- name: Save minikube images to cache
223218
if: steps.image-cache.outputs.cache-hit != 'true'
224219
run: devtools/ci/save-minikube-images.sh

devtools/Tiltfile

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -191,12 +191,3 @@ local_resource(
191191
labels=["setup"],
192192
)
193193

194-
# ---------------------------------------------------------------------------
195-
# Test image
196-
# ---------------------------------------------------------------------------
197-
local_resource(
198-
name="build-test-image",
199-
cmd="minikube image build -t metaflow-test:python3.9 docker/metaflow-test/",
200-
deps=["docker/metaflow-test/Dockerfile"],
201-
labels=["test"],
202-
)

devtools/docker/metaflow-test/Dockerfile

Lines changed: 0 additions & 6 deletions
This file was deleted.

test/ux/ux_test_config.yaml

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -23,37 +23,28 @@ backends:
2323
enabled: true
2424

2525
# Argo Workflows + Kubernetes (devstack: minikube + argo-workflows)
26-
# Uses a pre-baked image with boto3/requests to skip pip install in every pod.
27-
# Build it once: docker build -t metaflow-test:python3.9 devtools/docker/metaflow-test/
2826
- name: argo-kubernetes
2927
scheduler_type: argo-workflows
3028
cluster: default
31-
decospec: "kubernetes:image=metaflow-test:python3.9,image_pull_policy=Never"
29+
decospec: "kubernetes:image=python:3.9"
3230
enabled: true
3331

3432
# AWS Step Functions Local + Batch/localbatch (devstack: sfn-local + localbatch)
35-
# Uses a pre-baked image with boto3/requests to skip pip install in every container.
36-
# Build it once: docker build -t metaflow-test:python3.9 devtools/docker/metaflow-test/
3733
- name: sfn-batch
3834
scheduler_type: step-functions
3935
cluster: null
40-
decospec: "batch:image=metaflow-test:python3.9"
36+
decospec: "batch:image=python:3.9"
4137
enabled: true
4238
# xfail: requires core changes from npow/core-deployer-changes (step_functions.py
4339
# sfn-local compatibility fixes: ResultSelector on Parallel states, no ProcessorConfig
4440
# on Map states). Remove once that PR is merged into master.
4541
xfail_reason: "requires npow/core-deployer-changes (sfn-local compatibility fixes in step_functions.py)"
4642

4743
# Apache Airflow + Kubernetes (devstack: minikube + airflow helm chart)
48-
# Uses a pre-baked image with boto3/requests to skip pip install in every pod.
49-
# Build it once: docker build -t metaflow-test:python3.9 devtools/docker/metaflow-test/
5044
- name: airflow-kubernetes
5145
scheduler_type: airflow
5246
cluster: default
53-
# image_pull_policy is not supported by the Airflow deployer; omit it.
54-
# The image tag (python3.9) is non-latest so Kubernetes defaults to
55-
# IfNotPresent, which works fine since the image is pre-loaded into minikube.
56-
decospec: "kubernetes:image=metaflow-test:python3.9"
47+
decospec: "kubernetes:image=python:3.9"
5748
enabled: true
5849
# xfail: requires AirflowDeployer from npow/core-deployer-changes (__init__.py
5950
# registration + airflow_deployer.py + airflow_client.py).

0 commit comments

Comments
 (0)