style(tests): fix test naming convention violations

AnkushinDaniil · AnkushinDaniil · commit 1f4cc4e8c081 · 2026-03-04T19:17:18.000+04:00
Rename tests to follow SystemUnderTest_StateUnderTest_ExpectedBehavior:
- SetMultiGasConstraintsFromSingleGasConstraints_WhenCalled_ConvertsCorrectly
- SetMultiGasConstraintsFromSingleGasConstraints_WhenExistingConstraintsPresent_ClearsExisting
- MultiDimensionalPriceForRefund_WhenL1Calldata_UsesBaseFeeWei
- MultiDimensionalPriceForRefund_WhenZeroFee_UsesBaseFeeWei
diff --git a/src/Nethermind.Arbitrum.Test/Arbos/Storage/L2PricingStateTests.cs b/src/Nethermind.Arbitrum.Test/Arbos/Storage/L2PricingStateTests.cs
@@ -846,7 +846,7 @@ public void UpdatePricingModelMultiConstraints_DivisorZero_ThrowsException()
     #region Coverage: Migration Path
 
     [Test]
-    public void SetMultiGasConstraintsFromSingleGasConstraints_ConvertsCorrectly()
+    public void SetMultiGasConstraintsFromSingleGasConstraints_WhenCalled_ConvertsCorrectly()
     {
         IWorldState worldState = TestWorldStateFactory.CreateForTest();
         using IDisposable worldStateDisposer = worldState.BeginScope(IWorldState.PreGenesis);
@@ -923,7 +923,7 @@ public void SetMultiGasConstraintsFromSingleGasConstraints_LargeAdjustmentWindow
     }
 
     [Test]
-    public void SetMultiGasConstraintsFromSingleGasConstraints_ClearsExistingMultiGasConstraints()
+    public void SetMultiGasConstraintsFromSingleGasConstraints_WhenExistingConstraintsPresent_ClearsExisting()
     {
         IWorldState worldState = TestWorldStateFactory.CreateForTest();
         using IDisposable worldStateDisposer = worldState.BeginScope(IWorldState.PreGenesis);
@@ -1200,7 +1200,7 @@ public void CommitMultiGasFees_WhenMultiGasConstraints_CommitsNextToCurrent()
     }
 
     [Test]
-    public void MultiDimensionalPriceForRefund_L1CalldataUsesBaseFeeWei()
+    public void MultiDimensionalPriceForRefund_WhenL1Calldata_UsesBaseFeeWei()
     {
         IWorldState worldState = TestWorldStateFactory.CreateForTest();
         using IDisposable worldStateDisposer = worldState.BeginScope(IWorldState.PreGenesis);
@@ -1236,7 +1236,7 @@ public void MultiDimensionalPriceForRefund_L1CalldataUsesBaseFeeWei()
     }
 
     [Test]
-    public void MultiDimensionalPriceForRefund_ZeroFeeUsesBaseFeeWei()
+    public void MultiDimensionalPriceForRefund_WhenZeroFee_UsesBaseFeeWei()
     {
         IWorldState worldState = TestWorldStateFactory.CreateForTest();
         using IDisposable worldStateDisposer = worldState.BeginScope(IWorldState.PreGenesis);

Original file line number	Diff line number	Diff line change
`@@ -846,7 +846,7 @@ public void UpdatePricingModelMultiConstraints_DivisorZero_ThrowsException()`
`846`	`846`	`#region Coverage: Migration Path`
`847`	`847`
`848`	`848`	`[Test]`
`849`		`- public void SetMultiGasConstraintsFromSingleGasConstraints_ConvertsCorrectly()`
	`849`	`+ public void SetMultiGasConstraintsFromSingleGasConstraints_WhenCalled_ConvertsCorrectly()`
`850`	`850`	`{`
`851`	`851`	`IWorldState worldState = TestWorldStateFactory.CreateForTest();`
`852`	`852`	`using IDisposable worldStateDisposer = worldState.BeginScope(IWorldState.PreGenesis);`
`@@ -923,7 +923,7 @@ public void SetMultiGasConstraintsFromSingleGasConstraints_LargeAdjustmentWindow`
`923`	`923`	`}`
`924`	`924`
`925`	`925`	`[Test]`
`926`		`- public void SetMultiGasConstraintsFromSingleGasConstraints_ClearsExistingMultiGasConstraints()`
	`926`	`+ public void SetMultiGasConstraintsFromSingleGasConstraints_WhenExistingConstraintsPresent_ClearsExisting()`
`927`	`927`	`{`
`928`	`928`	`IWorldState worldState = TestWorldStateFactory.CreateForTest();`
`929`	`929`	`using IDisposable worldStateDisposer = worldState.BeginScope(IWorldState.PreGenesis);`
`@@ -1200,7 +1200,7 @@ public void CommitMultiGasFees_WhenMultiGasConstraints_CommitsNextToCurrent()`
`1200`	`1200`	`}`
`1201`	`1201`
`1202`	`1202`	`[Test]`
`1203`		`- public void MultiDimensionalPriceForRefund_L1CalldataUsesBaseFeeWei()`
	`1203`	`+ public void MultiDimensionalPriceForRefund_WhenL1Calldata_UsesBaseFeeWei()`
`1204`	`1204`	`{`
`1205`	`1205`	`IWorldState worldState = TestWorldStateFactory.CreateForTest();`
`1206`	`1206`	`using IDisposable worldStateDisposer = worldState.BeginScope(IWorldState.PreGenesis);`
`@@ -1236,7 +1236,7 @@ public void MultiDimensionalPriceForRefund_L1CalldataUsesBaseFeeWei()`
`1236`	`1236`	`}`
`1237`	`1237`
`1238`	`1238`	`[Test]`
`1239`		`- public void MultiDimensionalPriceForRefund_ZeroFeeUsesBaseFeeWei()`
	`1239`	`+ public void MultiDimensionalPriceForRefund_WhenZeroFee_UsesBaseFeeWei()`
`1240`	`1240`	`{`
`1241`	`1241`	`IWorldState worldState = TestWorldStateFactory.CreateForTest();`
`1242`	`1242`	`using IDisposable worldStateDisposer = worldState.BeginScope(IWorldState.PreGenesis);`