Skip to content

Commit 67c1cb4

Browse files
committed
Reintroduce missing 4844 RPC fields (GasPrice and V) (#8232)
1 parent 13e9c38 commit 67c1cb4

4 files changed

Lines changed: 0 additions & 22 deletions

File tree

src/Nethermind/Nethermind.Facade/Eth/RpcTransaction/BlobTransactionForRpc.cs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,6 @@ public class BlobTransactionForRpc : EIP1559TransactionForRpc, IFromTransaction<
2727
[JsonIgnore(Condition = JsonIgnoreCondition.WhenWritingNull)]
2828
public byte[][]? Blobs { get; set; }
2929

30-
[JsonIgnore(Condition = JsonIgnoreCondition.Always)]
31-
public override UInt256? GasPrice { get; set; }
32-
33-
[JsonIgnore(Condition = JsonIgnoreCondition.Always)]
34-
public override UInt256? V { get; set; }
35-
3630
[JsonConstructor]
3731
public BlobTransactionForRpc() { }
3832

src/Nethermind/Nethermind.Facade/Eth/RpcTransaction/SetCodeTransactionForRpc.cs

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,6 @@ public class SetCodeTransactionForRpc : EIP1559TransactionForRpc, IFromTransacti
1717
[JsonDiscriminator]
1818
public AuthorizationListForRpc AuthorizationList { get; set; }
1919

20-
#region Deprecated fields
21-
[JsonIgnore(Condition = JsonIgnoreCondition.Always)]
22-
public override UInt256? GasPrice { get; set; }
23-
24-
[JsonIgnore(Condition = JsonIgnoreCondition.Always)]
25-
public override UInt256? V { get; set; }
26-
#endregion
27-
2820
[JsonConstructor]
2921
public SetCodeTransactionForRpc() { }
3022

src/Nethermind/Nethermind.JsonRpc.Test/Modules/RpcTransaction/BlobTransactionForRpcTests.cs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -123,10 +123,6 @@ public static void ValidateSchema(JsonElement json)
123123
json.GetProperty("r").GetString().Should().MatchRegex("^0x([1-9a-f]+[0-9a-f]*|0)$");
124124
json.GetProperty("s").GetString().Should().MatchRegex("^0x([1-9a-f]+[0-9a-f]*|0)$");
125125

126-
// Assert deprecated fields are no longer serialized
127-
json.TryGetProperty("v", out _).Should().BeFalse();
128-
json.TryGetProperty("gasPrice", out _).Should().BeFalse();
129-
130126
// Assert deserialization-only are not serialized
131127
json.TryGetProperty("blobs", out _).Should().BeFalse();
132128
}

src/Nethermind/Nethermind.JsonRpc.Test/Modules/RpcTransaction/SetCodeTransactionForRpcTests.cs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -129,9 +129,5 @@ public static void ValidateSchema(JsonElement json)
129129
tuple.GetProperty("r").GetString().Should().MatchRegex("^0x([1-9a-f]+[0-9a-f]*|0)$");
130130
tuple.GetProperty("s").GetString().Should().MatchRegex("^0x([1-9a-f]+[0-9a-f]*|0)$");
131131
});
132-
133-
// Assert deprecated fields are no longer serialized
134-
json.TryGetProperty("gasPrice", out _).Should().BeFalse();
135-
json.TryGetProperty("v", out _).Should().BeFalse();
136132
}
137133
}

0 commit comments

Comments
 (0)