fix some leaks

Author: batrr

src/Nethermind/Nethermind.Consensus/Processing/BlockProcessor.cs

@@ -93,6 +93,7 @@ private void ValidateProcessedBlock(Block suggestedBlock, ProcessingOptions opti
     {
         if (!options.ContainsFlag(ProcessingOptions.NoValidation) && !blockValidator.ValidateProcessedBlock(block, receipts, suggestedBlock, out string? error))
         {
+            block.DisposeAccountChanges();
             if (_logger.IsWarn) _logger.Warn(InvalidBlockHelper.GetMessage(suggestedBlock, "invalid block after processing"));
             throw new InvalidBlockException(suggestedBlock, error);
         }

src/Nethermind/Nethermind.Network/P2P/MessageDictionary.cs

@@ -100,7 +100,8 @@ public void Handle(long id, TData data, long size)
         {
             Interlocked.Decrement(ref _requestCount);
             request.ResponseSize = size;
-            request.CompletionSource.TrySetResult(data);
+            if (!request.CompletionSource.TrySetResult(data))
+                data?.TryDispose();
         }
         else
         {

src/Nethermind/Nethermind.Network/P2P/Subprotocols/Eth/V62/Eth62ProtocolHandler.cs

@@ -237,6 +237,10 @@ protected void Handle(TransactionsMessage msg)
             IOwnedReadOnlyList<Transaction> iList = msg.Transactions;
             if (!BackgroundTaskScheduler.TryScheduleBackgroundTask(new TransactionsRequest(iList, 0), _handleSlow, "Transactions"))
             {
+                foreach (Transaction tx in iList)
+                {
+                    tx.ClearPreHash();
+                }
                 iList.Dispose();
             }
         }
@@ -245,43 +249,49 @@ protected virtual ValueTask HandleSlow(TransactionsRequest request, Cancellation
         {
             IOwnedReadOnlyList<Transaction> transactions = request.Transactions;
             ReadOnlySpan<Transaction> transactionsSpan = transactions.AsSpan();
+
+            int currentIdx = request.StartIndex;
+            bool isTrace = Logger.IsTrace;
+            bool isTransferred = false;
+
             try
             {
-                int startIdx = request.StartIndex;
-                bool isTrace = Logger.IsTrace;
-
-                for (int i = startIdx; i < transactionsSpan.Length; i++)
+                while (currentIdx < transactionsSpan.Length)
                 {
                     if (cancellationToken.IsCancellationRequested)
                     {
-                        if (i == startIdx)
+                        if (currentIdx == request.StartIndex)
                         {
                             // Cancelled before processing any transaction — dispose and bail out.
                             // Rescheduling would just loop (cancelled again immediately).
-                            transactions.Dispose();
                             return ValueTask.CompletedTask;
                         }
 
-                        // Reschedule remaining transactions with a different start index
-                        if (!BackgroundTaskScheduler.TryScheduleBackgroundTask(new TransactionsRequest(transactions, i), _handleSlow, "Transactions"))
+                        if (BackgroundTaskScheduler.TryScheduleBackgroundTask(new TransactionsRequest(transactions, currentIdx), _handleSlow, "Transactions"))
                         {
-                            transactions.Dispose();
+                            isTransferred = true;
                         }
+
                         return ValueTask.CompletedTask;
                     }
 
-                    PrepareAndSubmitTransaction(transactionsSpan[i], isTrace);
+                    PrepareAndSubmitTransaction(transactionsSpan[currentIdx], isTrace);
+                    currentIdx++;
                 }
-
-                transactions.Dispose();
             }
-            catch
+            finally
             {
-                transactions.Dispose();
-                throw;
+                if (!isTransferred)
+                {
+                    while (currentIdx < transactionsSpan.Length)
+                    {
+                        transactionsSpan[currentIdx].ClearPreHash();
+                        currentIdx++;
+                    }
+                    transactions.Dispose();
+                }
             }
 
-
             return ValueTask.CompletedTask;
         }
 

src/Nethermind/Nethermind.Network/P2P/Subprotocols/Eth/V62/Messages/TransactionsMessageSerializer.cs

@@ -62,6 +62,8 @@ public static IOwnedReadOnlyList<Transaction> DeserializeTxs(ref Rlp.ValueDecode
             }
             catch
             {
+                foreach (Transaction tx in result)
+                    tx.ClearPreHash();
                 result.Dispose();
                 throw;
             }

src/Nethermind/Nethermind.Network/P2P/Subprotocols/Eth/V68/Eth68ProtocolHandler.cs

@@ -260,6 +260,10 @@ protected override ValueTask HandleSlow(TransactionsRequest request, Cancellatio
         {
             if (!ValidateSizeAndType(transactionsSpan[i]))
             {
+                for (int j = startIdx; j < transactionsSpan.Length; j++)
+                {
+                    transactionsSpan[j].ClearPreHash();
+                }
                 transactions.Dispose();
                 throw new SubprotocolException("invalid pooled tx type or size");
             }