More graceful shutdown logs (#9177)

More graceful shutdown

Author: benaadams

src/Nethermind/Nethermind.Merge.Plugin/Synchronization/PeerRefresher.cs

@@ -28,6 +28,7 @@ public class PeerRefresher : IPeerRefresher, IAsyncDisposable
     private (Hash256 headBlockhash, Hash256 headParentBlockhash, Hash256 finalizedBlockhash) _lastBlockhashes = (Keccak.Zero, Keccak.Zero, Keccak.Zero);
     private readonly ITimer _refreshTimer;
     private readonly ILogger _logger;
+    private bool _disposed;
 
     public PeerRefresher(IPeerDifficultyRefreshPool syncPeerPool, ITimerFactory timerFactory, ILogManager logManager)
     {
@@ -40,6 +41,7 @@ public PeerRefresher(IPeerDifficultyRefreshPool syncPeerPool, ITimerFactory time
 
     public void RefreshPeers(Hash256 headBlockhash, Hash256 headParentBlockhash, Hash256 finalizedBlockhash)
     {
+        if (_disposed) return;
         _lastBlockhashes = (headBlockhash, headParentBlockhash, finalizedBlockhash);
         TimeSpan timePassed = DateTime.UtcNow - _lastRefresh;
         if (timePassed > _minRefreshDelay)
@@ -79,6 +81,10 @@ Hash256 finalizedBlockhash
         {
             await RefreshPeerForFcu(syncPeer, headBlockhash, headParentBlockhash, finalizedBlockhash, delaySource.Token);
         }
+        catch (OperationCanceledException)
+        {
+            if (_logger.IsDebug) _logger.Debug($"Peer refresh timed out.");
+        }
         catch (Exception exception)
         {
             if (_logger.IsError) _logger.Error($"Exception in peer refresh. This is unexpected. {syncPeer}", exception);
@@ -199,7 +205,11 @@ private static bool TryGetHeadAndParent(Hash256 headBlockhash, Hash256 headParen
 
     public ValueTask DisposeAsync()
     {
-        _refreshTimer.Dispose();
+        if (!_disposed)
+        {
+            _disposed = true;
+            _refreshTimer.Dispose();
+        }
         return default;
     }
 }

src/Nethermind/Nethermind.State/VerifyTrieStarter.cs

@@ -43,7 +43,7 @@ public bool TryStartVerifyTrie(BlockHeader stateAtBlock)
             }
             catch (OperationCanceledException)
             {
-                if (_logger.IsError) _logger.Error($"Verify trie cancelled");
+                if (_logger.IsInfo) _logger.Info($"Verify trie cancelled");
             }
             catch (Exception e)
             {

src/Nethermind/Nethermind.Synchronization/SnapSync/SnapSyncDownloader.cs

@@ -46,6 +46,10 @@ public async Task Dispatch(PeerInfo peerInfo, SnapSyncBatch batch, CancellationT
                         batch.AccountsToRefreshResponse = await handler.GetTrieNodes(batch.AccountsToRefreshRequest, cancellationToken);
                     }
                 }
+                catch (OperationCanceledException)
+                {
+                    if (Logger.IsDebug) Logger.Debug($"Snap sync request cancelled. Request: {batch}");
+                }
                 catch (Exception e)
                 {
                     if (Logger.IsDebug)