Skip to content

proof_call lacks focused regression coverage for current gas semantics #11902

@peter941221

Description

@peter941221

proof_call currently routes the request transaction through tx.ToTransaction(validateUserInput: true, gasCap: jsonRpcConfig.GasCap) in Nethermind.JsonRpc/Modules/Proof/ProofRpcModule.cs, but the test suite does not lock the gas semantics on that path.

The underlying converter in Nethermind.Facade/Eth/RpcTransaction/LegacyTransactionForRpc.cs already documents the current contract:

  • Gas is null -> default to gasCap
  • explicit gas, including 0, -> keep the literal gas value and cap it only from above

I probed that behavior on current master with two focused tests:

  1. Proof_call_without_gas_defaults_to_gas_cap_not_block_gas_limit
  2. Proof_call_with_zero_gas_keeps_literal_zero_gas_semantics

Both passed.

That gives us a narrow regression-coverage gap:

  • omitted gas should keep following the gasCap path for proof_call
  • explicit gas: 0x0 should keep returning the current literal zero-gas failure instead of silently following the omitted-gas path

The missing piece is focused coverage for that existing contract.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions