-
Notifications
You must be signed in to change notification settings - Fork 95
Feature/partial First Pydantic Models for parameter validation #678
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JanNolten
wants to merge
29
commits into
NeuralEnsemble:master
Choose a base branch
from
JanNolten:feature/partial
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
f70c9cd
Added schemas Folder with __init__.py
JanNolten e007679
Added field_validator.py to group repeated validation
JanNolten ccac5cc
Added field_serializer.py to group repeated serialization
JanNolten 11c2a35
added function_validator.py to validate elephant functions
JanNolten 46ff38b
Added Pydantic Models for statistics
JanNolten 5fb18dc
Added Pydantic Models for spike_train_correlation
JanNolten d5324bf
Added Pydantic Models for spike_train_synchrony
JanNolten c99b6c0
Original arguments are passed into the function
JanNolten cb533cc
Added pytest.ini to .gitignore
JanNolten 71b7dc0
Added tests and option to skip validation
JanNolten 7f4f5ef
Transfering Bug fixes
JanNolten b282cc3
Transfering Bug fixes
JanNolten 9c3402a
Transfering Bug fixes
JanNolten ac00866
Implemented validation for statistics
JanNolten a95f9f8
Implemented validation for spike_train_correlation
JanNolten 69745c2
Implemented validation for spike_train_synchrony
JanNolten 460e9cd
Allowed some ValueErrors to also be TypeErrors
JanNolten bf9b837
Merge branch 'NeuralEnsemble:master' into feature/partial
JanNolten fac02e1
Removed ; at end of lines
JanNolten 4fdd64a
Added Pydantic to requirements
JanNolten b5f0ff7
Merge branch 'NeuralEnsemble:master' into feature/partial
JanNolten 7d933a4
Removed Self from typing, because it only works in python>=3.11.0
JanNolten 932f1d4
Added ability to disable validation globally
JanNolten 1f58b12
Allow t_start to be negative because it should be able to be used tha…
JanNolten 6f2b7d3
Allowed all t_start and t_stop to be negative, becuase they could be …
JanNolten c46228d
Removed the option to skip validation with the extra kwargs not_valid…
JanNolten ae94ee6
Simplified test to make them more understandable
JanNolten ca247c0
Make test stricter by checking for the exact Error Type. Also Fixed Bugs
JanNolten 91df787
Forgot to remove a print statement
JanNolten File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spiketrains is also allowed to be empty