Clip small negative values in van_rossum_distance before np.sqrt #680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rom np.sqrt; added test case for same
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes Issue #679 . Currently
van_rossum_distancecould returnnandue to extremely small negative values because of floating point errors before applyingnp.sqrt.Fix
Added check before
np.sqrtto find small negative values, then replaced them usingnp.maximum(vr_dist,0). Also outputs runtime warning for transparancy.This ensures that spike trains that should result in a distance of 0 no longer produce
nan.Test
Added unit test that reproduces the spike train scenario from the issue, it asserts that the computed distance is 0 and not
nan