Skip to content

Commit 3889e2b

Browse files
author
Sylvain Chevallier
authored
Merge pull request #287 from NeuroTechX/develop
Merge 0.4.6 into master
2 parents bc046ea + 5312214 commit 3889e2b

File tree

10 files changed

+701
-113
lines changed

10 files changed

+701
-113
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ one of the sections below, or just scroll down to find out more.
3333
- [Supported datasets](#supported-datasets)
3434
- [Who are we? n](#who-are-we)
3535
- [Get in touch](#contact-us)
36-
- [Documentation](#documentation)
36+
- [Documentation][link_moabb_docs]
3737
- [Architecture and main concepts](#architecture-and-main-concepts)
3838
- [Citing MOABB and related publications](#citing-moabb-and-related-publications)
3939

docs/source/datasets.rst

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,21 @@ ERP Datasets
4040
:toctree: generated/
4141
:template: class.rst
4242

43+
bi2012a
4344
bi2013a
45+
bi2014a
46+
bi2014b
47+
bi2015a
48+
bi2015b
4449
BNCI2014008
4550
BNCI2014009
4651
BNCI2015003
4752
DemonsP300
4853
EPFLP300
54+
Huebner2017
55+
Huebner2018
4956
Lee2019_ERP
57+
Sosulski2019
5058

5159

5260
--------------

docs/source/whats_new.rst

Lines changed: 19 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,30 @@ API changes
3030

3131
- None
3232

33-
34-
Version - 0.4.5 (Stable - PyPi)
33+
Version - 0.4.6 (Stable - PyPi)
3534
---------------------------------
3635

3736
Enhancements
3837
~~~~~~~~~~~~
3938

39+
- Add P300 BrainInvaders datasets (:gh:`283` by `Sylvain Chevallier`_)
40+
- Add explicit warning when lambda function are used to parametrize pipelines (:gh:`278` by `Jan Sosulski`_)
41+
42+
43+
Bugs
44+
~~~~
45+
46+
- Correct default path for ERP visualization (:gh:`279` by `Jan Sosulski`_)
47+
- Correct documentation (:gh:`282` and :gh:`284` by `Jan Sosulski`_)
48+
49+
50+
51+
Version - 0.4.5
52+
---------------
53+
54+
Enhancements
55+
~~~~~~~~~~~~
56+
4057
- Progress bars, pooch, tqdm (:gh:`258` by `Divyesh Narayanan`_ and `Sylvain Chevallier`_)
4158
- Adding test and example for set_download_dir (:gh:`249` by `Divyesh Narayanan`_)
4259
- Update to newer version of Schirrmeister2017 dataset (:gh:`265` by `Robin Schirrmeister`_)

moabb/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
# flake8: noqa
2-
__version__ = "0.4.5"
2+
__version__ = "0.4.6"
33

44
from moabb.utils import set_log_level

moabb/analysis/results.py

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
import os
33
import os.path as osp
44
import re
5+
import warnings
56
from datetime import datetime
67

78
import h5py
@@ -17,6 +18,15 @@ def get_string_rep(obj):
1718
str_repr = repr(obj.get_params())
1819
else:
1920
str_repr = repr(obj)
21+
if "<lambda> at " in str_repr:
22+
warnings.warn(
23+
"You are probably using a classifier with a lambda function"
24+
" as an attribute. Lambda functions can only be identified"
25+
" by memory address which MOABB does not consider. To avoid"
26+
" issues you can use named functions defined using the def"
27+
" keyword instead.",
28+
RuntimeWarning,
29+
)
2030
str_no_addresses = re.sub("0x[a-z0-9]*", "0x__", str_repr)
2131
return str_no_addresses.replace("\n", "").encode("utf8")
2232

moabb/datasets/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
BNCI2015003,
1818
BNCI2015004,
1919
)
20-
from .braininvaders import bi2013a
20+
from .braininvaders import bi2012, bi2013a, bi2014a, bi2014b, bi2015a, bi2015b
2121
from .epfl import EPFLP300
2222
from .gigadb import Cho2017
2323
from .huebner_llp import Huebner2017, Huebner2018

0 commit comments

Comments
 (0)