-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
category: bugerrors in the code or code behaviorerrors in the code or code behaviorpriority: highimpacts proper operation or use of a feature important to most usersimpacts proper operation or use of a feature important to most users
Description
Aappending new rows to the ElectrodesTable after it has been finalized does currently not work correctly. I.e., currently the ElectrodesTable still has to be created in one shot. #209 addressed finalization of ElectrodeTable to support multiple calls to ElectrodeTable.finalize. Appending to location and group_name should in principal already work, as DynamicTable.addColumn was updated in #209 to append values to a column if it already exists. However, the following issues remain:
-
DynamicTable.addReferenceColumndoes currently not support appending of values, i.e., appending values after finalize will result in invalid behavior - When an
ElectrodeTable(or anyDynamicTable) is being read from file, then theVectorDatashould be read from file to make sure we append to existing data. We should check that this actually happens. -
finalizeshould be save to call multiple times on bothDynamicTableandElectrodeTable. Add test to confirm thatElectrodeTable::finalize()can be called again when appending to an existing table.
Metadata
Metadata
Assignees
Labels
category: bugerrors in the code or code behaviorerrors in the code or code behaviorpriority: highimpacts proper operation or use of a feature important to most usersimpacts proper operation or use of a feature important to most users