Merge pull request #106 from NeurodataWithoutBorders/dataset-compression-property

dummy compression and compression_opts on dataset

Author: magland

.github/workflows/integration_tests.yml

@@ -14,12 +14,9 @@ jobs:
     - name: Install
       run: pip install .
     - name: Install packages needed for tests
-      # pyright 1.1.336 can produce annoying errors
-      run: pip install pytest pytest-cov pyright==1.1.335
+      run: pip install pytest pytest-cov
     - name: Install pynwb needed for tests
       run: pip install pynwb
-    - name: Run pyright
-      run: cd lindi && pyright
     - name: Run tests and collect coverage
       run: pytest --cov lindi --cov-report=xml --cov-report=term tests/
     - name: Upload coverage reports to Codecov

.github/workflows/linter_checks.yml

@@ -14,9 +14,6 @@ jobs:
     - name: Install
       run: pip install .
     - name: Install packages needed for tests
-      # pyright 1.1.336 can produce annoying errors
-      run: pip install pyright==1.1.335 flake8 pytest
+      run: pip install flake8 pytest
     - name: Run flake8
       run: cd lindi && flake8 --config ../.flake8
-    - name: Run pyright
-      run: cd lindi && pyright .

.vscode/tasks/quick_test.sh

@@ -5,7 +5,6 @@ set -ex
 
 cd lindi
 flake8 .
-# pyright
 cd ..
 
 pytest --cov=lindi --cov-report=xml --cov-report=term -m "not slow and not network" tests/

.vscode/tasks/test.sh

@@ -5,7 +5,6 @@ set -ex
 
 cd lindi
 flake8 .
-pyright .
 cd ..
 
 pytest --cov=lindi --cov-report=xml --cov-report=term tests/

lindi/LindiH5pyFile/LindiH5pyDataset.py

@@ -154,6 +154,16 @@ def fletcher32(self):
                 return True
         return False
 
+    @property
+    def compression(self):
+        # Return dummy value so we don't break hdmf
+        return None
+
+    @property
+    def compression_opts(self):
+        # Return dummy value so we don't break hdmf
+        return None
+
     @property
     def chunks(self):
         return self._zarr_array.chunks

lindi/LindiRemfile/LindiRemfile.py

@@ -201,7 +201,7 @@ def _load_chunk(self, chunk_index: int) -> bytes:
         )
         if self._verbose:
             print(
-                f"Loading {self._smart_loader_chunk_sequence_length} chunks starting at {chunk_index} ({(data_end - data_start + 1)/1e6} million bytes)"
+                f"Loading {self._smart_loader_chunk_sequence_length} chunks starting at {chunk_index} ({(data_end - data_start + 1) / 1e6} million bytes)"
             )
         if data_end >= self.length:
             data_end = self.length - 1

pyproject.toml

@@ -22,7 +22,6 @@ pynwb = "^2.6.0"
 pytest = "^7.4.4"
 pytest-cov = "^4.1.0"
 ruff = "^0.3.3"
-pyright = "1.1.335"
 
 [build-system]
 requires = ["poetry-core"]