Skip to content

Commit 0c7896b

Browse files
authored
Revert "Create new ElectrodesTable neurodata type (#539)" (#618)
1 parent f3cd9f8 commit 0c7896b

File tree

3 files changed

+66
-77
lines changed

3 files changed

+66
-77
lines changed

core/nwb.ecephys.yaml

Lines changed: 0 additions & 69 deletions
Original file line numberDiff line numberDiff line change
@@ -257,75 +257,6 @@ groups:
257257
target_type: Device
258258
doc: Link to the device that was used to record from this electrode group.
259259

260-
- neurodata_type_def: ElectrodesTable
261-
neurodata_type_inc: DynamicTable
262-
doc: A table of all electrodes (i.e. channels) used for recording. Introduced in NWB 2.8.0. Replaces the "electrodes"
263-
table (neurodata_type_inc DynamicTable, no neurodata_type_def) that is part of NWBFile.
264-
datasets:
265-
- name: location
266-
neurodata_type_inc: VectorData
267-
dtype: text
268-
doc: Location of the electrode (channel). Specify the area, layer, comments
269-
on estimation of area/layer, stereotaxic coordinates if in vivo, etc. Use
270-
standard atlas names for anatomical regions when possible.
271-
- name: group
272-
neurodata_type_inc: VectorData
273-
dtype:
274-
target_type: ElectrodeGroup
275-
reftype: object
276-
doc: Reference to the ElectrodeGroup this electrode is a part of.
277-
- name: group_name
278-
neurodata_type_inc: VectorData
279-
dtype: text
280-
doc: Name of the ElectrodeGroup this electrode is a part of.
281-
quantity: '?'
282-
- name: x
283-
neurodata_type_inc: VectorData
284-
dtype: float32
285-
doc: x coordinate of the channel location in the brain (+x is posterior).
286-
quantity: '?'
287-
- name: y
288-
neurodata_type_inc: VectorData
289-
dtype: float32
290-
doc: y coordinate of the channel location in the brain (+y is inferior).
291-
quantity: '?'
292-
- name: z
293-
neurodata_type_inc: VectorData
294-
dtype: float32
295-
doc: z coordinate of the channel location in the brain (+z is right).
296-
quantity: '?'
297-
- name: imp
298-
neurodata_type_inc: VectorData
299-
dtype: float32
300-
doc: Impedance of the channel, in ohms.
301-
quantity: '?'
302-
- name: filtering
303-
neurodata_type_inc: VectorData
304-
dtype: text
305-
doc: Description of hardware filtering, including the filter name and frequency cutoffs.
306-
quantity: '?'
307-
- name: rel_x
308-
neurodata_type_inc: VectorData
309-
dtype: float32
310-
doc: x coordinate in electrode group
311-
quantity: '?'
312-
- name: rel_y
313-
neurodata_type_inc: VectorData
314-
dtype: float32
315-
doc: y coordinate in electrode group
316-
quantity: '?'
317-
- name: rel_z
318-
neurodata_type_inc: VectorData
319-
dtype: float32
320-
doc: z coordinate in electrode group
321-
quantity: '?'
322-
- name: reference
323-
neurodata_type_inc: VectorData
324-
dtype: text
325-
doc: Description of the reference electrode and/or reference scheme used for this electrode, e.g.,
326-
"stainless steel skull screw" or "online common average referencing".
327-
quantity: '?'
328-
329260
# The types below have been deprecated
330261
- neurodata_type_def: ClusterWaveforms
331262
neurodata_type_inc: NWBDataInterface

core/nwb.file.yaml

Lines changed: 65 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -292,10 +292,72 @@ groups:
292292
doc: Physical group of electrodes.
293293
quantity: '*'
294294
- name: electrodes
295-
neurodata_type_inc: ElectrodesTable
296-
doc: A table of all electrodes (i.e. channels) used for recording. Changed in NWB 2.9.0 to use the newly added
297-
ElectrodesTable neurodata type instead of a DynamicTable with added columns.
295+
neurodata_type_inc: DynamicTable
296+
doc: A table of all electrodes (i.e. channels) used for recording.
298297
quantity: '?'
298+
datasets:
299+
- name: x
300+
neurodata_type_inc: VectorData
301+
dtype: float32
302+
doc: x coordinate of the channel location in the brain (+x is posterior).
303+
quantity: '?'
304+
- name: y
305+
neurodata_type_inc: VectorData
306+
dtype: float32
307+
doc: y coordinate of the channel location in the brain (+y is inferior).
308+
quantity: '?'
309+
- name: z
310+
neurodata_type_inc: VectorData
311+
dtype: float32
312+
doc: z coordinate of the channel location in the brain (+z is right).
313+
quantity: '?'
314+
- name: imp
315+
neurodata_type_inc: VectorData
316+
dtype: float32
317+
doc: Impedance of the channel, in ohms.
318+
quantity: '?'
319+
- name: location
320+
neurodata_type_inc: VectorData
321+
dtype: text
322+
doc: Location of the electrode (channel). Specify the area, layer, comments
323+
on estimation of area/layer, stereotaxic coordinates if in vivo, etc. Use
324+
standard atlas names for anatomical regions when possible.
325+
- name: filtering
326+
neurodata_type_inc: VectorData
327+
dtype: text
328+
doc: Description of hardware filtering, including the filter name and frequency cutoffs.
329+
quantity: '?'
330+
- name: group
331+
neurodata_type_inc: VectorData
332+
dtype:
333+
target_type: ElectrodeGroup
334+
reftype: object
335+
doc: Reference to the ElectrodeGroup this electrode is a part of.
336+
- name: group_name
337+
neurodata_type_inc: VectorData
338+
dtype: text
339+
doc: Name of the ElectrodeGroup this electrode is a part of.
340+
- name: rel_x
341+
neurodata_type_inc: VectorData
342+
dtype: float32
343+
doc: x coordinate in electrode group
344+
quantity: '?'
345+
- name: rel_y
346+
neurodata_type_inc: VectorData
347+
dtype: float32
348+
doc: y coordinate in electrode group
349+
quantity: '?'
350+
- name: rel_z
351+
neurodata_type_inc: VectorData
352+
dtype: float32
353+
doc: z coordinate in electrode group
354+
quantity: '?'
355+
- name: reference
356+
neurodata_type_inc: VectorData
357+
dtype: text
358+
doc: Description of the reference electrode and/or reference scheme used for this electrode, e.g.,
359+
"stainless steel skull screw" or "online common average referencing".
360+
quantity: '?'
299361
- name: intracellular_ephys
300362
doc: Metadata related to intracellular electrophysiology.
301363
quantity: '?'

docs/format/source/format_release_notes.rst

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,7 @@ Release Notes
44
=============
55

66
2.9.0 (Upcoming)
7-
------------------------
8-
9-
Major changes
10-
^^^^^^^^^^^^^
11-
- Changed ``NWBFile.electrodes`` from a generic ``DynamicTable`` with added columns to an ``ElectrodesTable`` that extends ``DynamicTable`` with added columns. (#539)
7+
----------------
128

139
Major changes
1410
^^^^^^^^^^^^^

0 commit comments

Comments
 (0)