From 1e27ed262ec22acf8c89c295345b64b1f50c3f8c Mon Sep 17 00:00:00 2001 From: Ryan Ly Date: Fri, 8 Nov 2024 14:13:42 -0500 Subject: [PATCH 1/5] Add Device.model_number --- core/nwb.device.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/core/nwb.device.yaml b/core/nwb.device.yaml index d883e59a..717b5e22 100644 --- a/core/nwb.device.yaml +++ b/core/nwb.device.yaml @@ -12,3 +12,7 @@ groups: dtype: text doc: The name of the manufacturer of the device. required: false + - name: model_number + dtype: text + doc: The model number of the device. + required: false From 66577fbf03a6f5af92955e94eb98a717f39f581b Mon Sep 17 00:00:00 2001 From: Ryan Ly Date: Fri, 8 Nov 2024 14:25:49 -0500 Subject: [PATCH 2/5] Add Device model_name and serial_number --- core/nwb.device.yaml | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/core/nwb.device.yaml b/core/nwb.device.yaml index 717b5e22..6684ddd9 100644 --- a/core/nwb.device.yaml +++ b/core/nwb.device.yaml @@ -10,9 +10,17 @@ groups: required: false - name: manufacturer dtype: text - doc: The name of the manufacturer of the device. + doc: The name of the manufacturer of the device, e.g., Imec, Plexon, Thorlabs. required: false - name: model_number dtype: text - doc: The model number of the device. + doc: The model number (or part/product number) of the device, e.g., PRB_1_4_0480_1, PLX-VP-32-15SE(75)-(260-80)(460-10)-300-(1)CON/32m-V, BERGAMO. required: false + - name: model_name + dtype: text + doc: The model name of the device, e.g., Neuropixels 1.0, V-Probe, Bergamo III. + required: false + - name: serial_number + dtype: text + doc: The serial number of the device. + required: false \ No newline at end of file From c5facc3bc113d871138c7291438e7f92b15d7c5b Mon Sep 17 00:00:00 2001 From: Ryan Ly Date: Fri, 8 Nov 2024 14:28:20 -0500 Subject: [PATCH 3/5] Update release notes --- docs/format/source/format_release_notes.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/format/source/format_release_notes.rst b/docs/format/source/format_release_notes.rst index f573ffdd..28e3b76f 100644 --- a/docs/format/source/format_release_notes.rst +++ b/docs/format/source/format_release_notes.rst @@ -15,8 +15,8 @@ Minor changes electrode and unit. (#576) - Added optional ``was_generated_by`` attribute to ``NWBFile`` to store provenance information (#578) - Deprecated ``EventWaveform`` neurodata type. (#584) - - Deprecated ``ImageMaskSeries`` neurodata type. (#583) +- Added `Device.model_number`, `Device.model_name`, `Device.serial_number` (#594) 2.7.0 (February 7, 2024) ------------------------ From 0fd1d95a8df6d15adc5609fba19910d338f84ef7 Mon Sep 17 00:00:00 2001 From: Ryan Ly Date: Fri, 8 Nov 2024 12:13:09 -0800 Subject: [PATCH 4/5] Update nwb.device.yaml --- core/nwb.device.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/core/nwb.device.yaml b/core/nwb.device.yaml index 6684ddd9..5f1a993d 100644 --- a/core/nwb.device.yaml +++ b/core/nwb.device.yaml @@ -5,8 +5,8 @@ groups: attributes: - name: description dtype: text - doc: Description of the device (e.g., model, firmware version, processing software version, etc.) - as free-form text. + doc: Description of the device as free-form text. If there is any software/firmware associated + with the device, the names and versions of those can be added to NWBFile.was_generated_by. required: false - name: manufacturer dtype: text @@ -23,4 +23,4 @@ groups: - name: serial_number dtype: text doc: The serial number of the device. - required: false \ No newline at end of file + required: false From 8dba7ad58c0051c49adb2e18dae62a7a4f55a68f Mon Sep 17 00:00:00 2001 From: Ryan Ly Date: Fri, 8 Nov 2024 12:13:20 -0800 Subject: [PATCH 5/5] Update docs/format/source/format_release_notes.rst Co-authored-by: Steph Prince <40640337+stephprince@users.noreply.github.com> --- docs/format/source/format_release_notes.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/format/source/format_release_notes.rst b/docs/format/source/format_release_notes.rst index 28e3b76f..f75bb335 100644 --- a/docs/format/source/format_release_notes.rst +++ b/docs/format/source/format_release_notes.rst @@ -16,7 +16,7 @@ Minor changes - Added optional ``was_generated_by`` attribute to ``NWBFile`` to store provenance information (#578) - Deprecated ``EventWaveform`` neurodata type. (#584) - Deprecated ``ImageMaskSeries`` neurodata type. (#583) -- Added `Device.model_number`, `Device.model_name`, `Device.serial_number` (#594) +- Added ``Device.model_number``, ``Device.model_name``, ``Device.serial_number`` (#594) 2.7.0 (February 7, 2024) ------------------------