From 23ce8252645c45b91f06ca5552bc4e4260d9b5e2 Mon Sep 17 00:00:00 2001 From: Ryan Ly Date: Thu, 8 May 2025 10:39:21 -0700 Subject: [PATCH 1/3] Use ExternalImage.data instead of file_path --- core/nwb.base.yaml | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/core/nwb.base.yaml b/core/nwb.base.yaml index 971a1a36..3f25b6d6 100644 --- a/core/nwb.base.yaml +++ b/core/nwb.base.yaml @@ -64,12 +64,10 @@ datasets: - neurodata_type_def: ExternalImage neurodata_type_inc: BaseImage - doc: A type for referencing an external image file. - attributes: - - name: file_path - dtype: text - doc: Path or URL to the external image file. - required: true + doc: A type for referencing an external image file. The single file path or URL to the external image file should + be stored in the dataset. + dtype: text + # shape: scalar # this will be supported in the NWB schema language 2.0 - neurodata_type_def: ImageReferences neurodata_type_inc: NWBData From 5105b0082be2b91aac77b0c635efc9e72b8b6a4d Mon Sep 17 00:00:00 2001 From: Ryan Ly Date: Thu, 8 May 2025 11:55:32 -0700 Subject: [PATCH 2/3] Update format_release_notes.rst --- docs/format/source/format_release_notes.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/format/source/format_release_notes.rst b/docs/format/source/format_release_notes.rst index 7904d441..26bd3fa3 100644 --- a/docs/format/source/format_release_notes.rst +++ b/docs/format/source/format_release_notes.rst @@ -8,7 +8,7 @@ Release Notes Major changes ^^^^^^^^^^^^^ -- Added `BaseImage` and `ExternalImage` as new neurodata types. The first so both `Image` and `ExternalImage` can inherit from it. The second to store external images (#604) +- Added `BaseImage` and `ExternalImage` as new neurodata types. The first so both `Image` and `ExternalImage` can inherit from it. The second to store external images (#604, #623) Minor changes ^^^^^^^^^^^^^ From 276270f26259bf69c54bca2d73ef3efae6c70907 Mon Sep 17 00:00:00 2001 From: Ryan Ly Date: Thu, 8 May 2025 15:57:22 -0700 Subject: [PATCH 3/3] Update core/nwb.base.yaml Co-authored-by: Steph Prince <40640337+stephprince@users.noreply.github.com> --- core/nwb.base.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/core/nwb.base.yaml b/core/nwb.base.yaml index 3f25b6d6..5da0e8c7 100644 --- a/core/nwb.base.yaml +++ b/core/nwb.base.yaml @@ -65,7 +65,8 @@ datasets: - neurodata_type_def: ExternalImage neurodata_type_inc: BaseImage doc: A type for referencing an external image file. The single file path or URL to the external image file should - be stored in the dataset. + be stored in the dataset. This type should NOT be used if the image is stored + in another NWB file and that file is linked to this file. dtype: text # shape: scalar # this will be supported in the NWB schema language 2.0