use dandi for lindi download benchmark

Author: stephprince

src/nwb_benchmarks/benchmarks/params_remote_download.py

@@ -62,20 +62,22 @@
         https_url=get_https_url(
             dandiset_id="213889",
             dandi_path="sub-npI3/sub-npI3_behavior+ecephys.nwb.lindi.json",
+            follow_redirects=False,
         ),
     ),
     dict(
         name="OphysTestCase",
         https_url=get_https_url(
             dandiset_id="213889",
             dandi_path="sub-R6_ses-20200206T210000_behavior+ophys/sub-R6_ses-20200206T210000_behavior+ophys.lindi.json",
+            follow_redirects=False,
         ),
     ),
     dict(
         name="IcephysTestCase",
         https_url=get_https_url(
             dandiset_id="213889",
             dandi_path="sub-1214579789_ses-1214621812_icephys/sub-1214579789_ses-1214621812_icephys.lindi.json",
-        ),
+            follow_redirects=False,),
     ),
 )

src/nwb_benchmarks/benchmarks/time_download.py

@@ -1,13 +1,12 @@
 """Basic benchmarks for timing download of remote NWB files using different methods."""
 
-import os
 import shutil
 
 from asv_runner.benchmarks.mark import skip_benchmark_if
 from dandi.download import download
 
 from nwb_benchmarks import RUN_DOWNLOAD_BENCHMARKS
-from nwb_benchmarks.core import BaseBenchmark, download_file
+from nwb_benchmarks.core import BaseBenchmark
 from nwb_benchmarks.setup import get_temporary_directory
 
 from .params_remote_download import hdf5_params, lindi_remote_rfs_params, zarr_params
@@ -56,22 +55,14 @@ def time_download_zarr_dandi_api(self, params: dict[str, str]):
         download(urls=params["https_url"], output_dir=self.tmpdir.name)
 
 
-class LindiDownloadFsspecBenchmark(BaseBenchmark):
+class LindiDownloadDandiAPIBenchmark(BaseDownloadDandiAPIBenchmark):
     """
     Time the download of a remote LINDI JSON file.
     """
 
     params = lindi_remote_rfs_params
 
-    def setup(self, params: dict[str, str]):
-        https_url = params["https_url"]
-        self.lindi_file = os.path.basename(https_url) + ".lindi.json"
-        self.teardown(params)
-
-    def teardown(self, params: dict[str, str]):
-        if os.path.exists(self.lindi_file):
-            os.remove(self.lindi_file)
-
-    def time_download_lindi_fsspec(self, params: dict[str, str]):
-        https_url = params["https_url"]
-        download_file(url=https_url, local_path=self.lindi_file)
+    @skip_benchmark_if(not RUN_DOWNLOAD_BENCHMARKS)
+    def time_download_lindi_dandi_api(self, params: dict[str, str]):
+        """Download a remote Lindi file using the DANDI API."""
+        download(urls=params["https_url"], output_dir=self.tmpdir.name)