Capture the network interface environment variable in the machine json

[rly]

We might run the benchmark suite on the same machine using ethernet and using wifi. Wifi will have more dropped packets and a slower speed. We should be able to track which network interface we used, which is currently passed in as an environment variable for tshark to use, if it is set.

We could also store the ifconfig (or equivalent on windows) but I don't think we should expose everyone's device mac addresses and ip addresses.

[CodyCBakerPhD]

We could also store the ifconfig (or equivalent on windows) but I don't think we should expose everyone's device mac addresses and ip addresses.

Absolutely not, since that violates all kinds of European privacy laws. I've talked about anonymization approaches as well with Yarik in relation to the access-summaries project, and that is quite tricky since there is usually 'some way' to de-identify individuals even without directly recovering the actual IP value

I think if you just add the tshark environment variable to the machine file schema/capture process, that should lead to good enough identification

[CodyCBakerPhD]

I do wish there was a basic way of determining Wifi vs ethernet besides the tshark variable name

But perhaps a more robust way of 'effectively' testing would be to just have a small calibration benchmark against some common speed test API - there seem to be several but they all require a personal API key it seems