Clarify 'or' requirement in message for subject age + DOB (#411)

* swap and to or in message

* fix test

* pr suggestions

* add parallel date of birth check

* changelog

* add to DANDI config

* remove other function

* Update dandi.inspector_config.yaml

* Update CHANGELOG.md

Author: CodyCBakerPhD

src/nwbinspector/checks/nwbfile_metadata.py

@@ -132,11 +132,12 @@ def check_doi_publications(nwbfile: NWBFile):
 @register_check(importance=Importance.BEST_PRACTICE_SUGGESTION, neurodata_type=Subject)
 def check_subject_age(subject: Subject):
     """Check if the Subject age is in ISO 8601 or our extension of it for ranges."""
-    if subject.age is None:
-        if subject.date_of_birth is None:
-            return InspectorMessage(message="Subject is missing age and date_of_birth.")
-        else:
-            return
+    if subject.age is None and subject.date_of_birth is None:
+        return InspectorMessage(
+            message="Subject is missing age and date_of_birth. Please specify at least one of these fields."
+        )
+    elif subject.age is None and subject.date_of_birth is not None:
+        return
     if re.fullmatch(pattern=duration_regex, string=subject.age):
         return
 

tests/unit_tests/test_nwbfile_metadata.py

@@ -336,7 +336,7 @@ def test_pass_check_subject_age_with_dob():
 def test_check_subject_age_missing():
     subject = Subject(subject_id="001")
     assert check_subject_age(subject) == InspectorMessage(
-        message="Subject is missing age and date_of_birth.",
+        message="Subject is missing age and date_of_birth. Please specify at least one of these fields.",
         importance=Importance.BEST_PRACTICE_SUGGESTION,
         check_function_name="check_subject_age",
         object_type="Subject",