hotfix logic

Author: CodyCBakerPhD

tests/test_inspector.py

@@ -28,7 +28,7 @@
 from nwbinspector.tools import make_minimal_nwbfile
 from nwbinspector.utils import FilePathType
 
-DISABLE_STREAMING_TESTS, DISABLE_STREAMING_TESTS_REASON = check_streaming_tests_enabled()
+STREAMING_TESTS_ENABLED, DISABLED_STREAMING_TESTS_REASON = check_streaming_tests_enabled()
 
 
 def add_big_dataset_no_compression(nwbfile: NWBFile):
@@ -560,7 +560,7 @@ def test_inspect_nwb_dandi_config(self):
         self.assertCountEqual(first=test_results, second=true_results)
 
 
-@pytest.mark.skipif(DISABLE_STREAMING_TESTS, reason="Needs h5py setup with ROS3.")
+@pytest.mark.skipif(not STREAMING_TESTS_ENABLED, reason=DISABLED_STREAMING_TESTS_REASON or "")
 def test_dandiset_streaming():
     messages = list(inspect_all(path="000126", select=["check_subject_species_exists"], stream=True))
     assert messages[0] == InspectorMessage(
@@ -574,7 +574,7 @@ def test_dandiset_streaming():
     )
 
 
-@pytest.mark.skipif(DISABLE_STREAMING_TESTS, reason="Needs h5py setup with ROS3.")
+@pytest.mark.skipif(not STREAMING_TESTS_ENABLED, reason=DISABLED_STREAMING_TESTS_REASON or "")
 def test_dandiset_streaming_parallel():
     messages = list(inspect_all(path="000126", select=["check_subject_species_exists"], stream=True, n_jobs=2))
     assert messages[0] == InspectorMessage(
@@ -588,7 +588,7 @@ def test_dandiset_streaming_parallel():
     )
 
 
-@pytest.mark.skipif(DISABLE_STREAMING_TESTS, reason=DISABLE_STREAMING_TESTS_REASON or "")
+@pytest.mark.skipif(not STREAMING_TESTS_ENABLED, reason=DISABLED_STREAMING_TESTS_REASON or "")
 class TestStreamingCLI(TestCase):
     @classmethod
     def setUpClass(cls):

tests/unit_tests/test_time_series.py

@@ -16,7 +16,7 @@
 from nwbinspector.testing import check_streaming_tests_enabled
 from nwbinspector.utils import get_package_version, robust_s3_read
 
-DISABLE_STREAMING_TESTS, DISABLE_STREAMING_TESTS_REASON = check_streaming_tests_enabled()
+STREAMING_TESTS_ENABLED, DISABLED_STREAMING_TESTS_REASON = check_streaming_tests_enabled()
 
 
 def test_check_regular_timestamps():
@@ -167,8 +167,8 @@ def test_check_unknown_resolution_pass():
 
 
 @pytest.mark.skipif(
-    DISABLE_STREAMING_TESTS or get_package_version("hdmf") >= version.parse("3.3.1"),
-    reason=f"{DISABLE_STREAMING_TESTS_REASON}. Also needs 'hdmf<3.3.1'.",
+    not STREAMING_TESTS_ENABLED or get_package_version("hdmf") >= version.parse("3.3.1"),
+    reason=f"{DISABLED_STREAMING_TESTS_REASON or ''}. Also needs 'hdmf<3.3.1'.",
 )
 def test_check_none_matnwb_resolution_pass():
     """
@@ -186,8 +186,8 @@ def test_check_none_matnwb_resolution_pass():
     ) as io:
         nwbfile = robust_s3_read(command=io.read)
         time_series = robust_s3_read(
-            "20170203_KIB_01_s1.1.h264",
             command=nwbfile.processing["video_files"]["video"].time_series.get,
+            command_args=["20170203_KIB_01_s1.1.h264"],
         )
     assert check_resolution(time_series) is None