Skip to content

Commit a693825

Browse files
authored
Add python 3.13 support (#564)
* add python 3.13 support * add cross-platform abspath support * update CHANGELOG
1 parent dc0cef2 commit a693825

File tree

10 files changed

+13
-11
lines changed

10 files changed

+13
-11
lines changed

.github/ISSUE_TEMPLATE/bug_report.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ body:
4040
- "3.10"
4141
- "3.11"
4242
- "3.12"
43+
- "3.13"
4344
- type: dropdown
4445
id: streaming
4546
attributes:

.github/workflows/dandi-dev-live-services.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
- name: Setup Python
1717
uses: actions/setup-python@v5
1818
with:
19-
python-version: "3.12"
19+
python-version: "3.13"
2020

2121
- name: Test against DANDI dev
2222
run: |

.github/workflows/dandi-dev.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
- name: Setup Python
2020
uses: actions/setup-python@v5
2121
with:
22-
python-version: "3.12"
22+
python-version: "3.13"
2323

2424
- name: Test local branch of NWB Inspector against DANDI dev branch
2525
run: |

.github/workflows/read-nwbfile-tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ jobs:
1616
fail-fast: false
1717
matrix:
1818
os: ["ubuntu-latest", "windows-latest"] # TODO: update mac and streaming methods
19-
python-version: ["3.9", "3.10", "3.11", "3.12"]
19+
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
2020
steps:
2121
- uses: conda-incubator/setup-miniconda@v3
2222
with:

.github/workflows/streaming-tests.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
fail-fast: false
1414
matrix:
1515
os: ["ubuntu-latest", "windows-latest"] # TODO: update mac and streaming methods
16-
python-version: ["3.9", "3.10", "3.11", "3.12"]
16+
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
1717
steps:
1818
- uses: actions/checkout@v4
1919
- run: git fetch --prune --unshallow --tags
@@ -59,7 +59,7 @@ jobs:
5959
fail-fast: false
6060
matrix:
6161
os: ["ubuntu-latest"]
62-
python-version: ["3.12"]
62+
python-version: ["3.13"]
6363
steps:
6464
- uses: actions/checkout@v4
6565
- run: git fetch --prune --unshallow --tags

.github/workflows/testing.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
fail-fast: false
1414
matrix:
1515
os: ["ubuntu-latest", "macos-13", "windows-latest"]
16-
python-version: ["3.9", "3.10", "3.11", "3.12"]
16+
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
1717
env:
1818
TESTING_FILES_FOLDER_PATH: ./204919/testing_files/
1919
steps:
@@ -53,7 +53,7 @@ jobs:
5353
fail-fast: false
5454
matrix:
5555
os: ["ubuntu-latest"]
56-
python-version: ["3.12"]
56+
python-version: ["3.13"]
5757
steps:
5858
- uses: actions/checkout@v4
5959
- run: git fetch --prune --unshallow --tags

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
### Improvements
44
* Added support for PyNWB 3.0 [#557](https://github.com/NeurodataWithoutBorders/nwbinspector/pull/557)
5+
* Added support for Python 3.13 [#564](https://github.com/NeurodataWithoutBorders/nwbinspector/pull/564)
56

67

78
# v0.6.2

docs/user_guide/installation.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ If you haven't checked it out already, please read the :nwb-overview:`NWB Overvi
66

77
The NWBInspector tool offers convenient command-line usage via any standard Conda or Python terminal.
88

9-
To install the package in any generic Python v3.9-v3.12 environment, simply type
9+
To install the package in any generic Python v3.9-v3.13 environment, simply type
1010

1111
::
1212

pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ classifiers = [
2626
"Programming Language :: Python :: 3.10",
2727
"Programming Language :: Python :: 3.11",
2828
"Programming Language :: Python :: 3.12",
29+
"Programming Language :: Python :: 3.13",
2930
"Operating System :: POSIX :: Linux",
3031
"Operating System :: Microsoft :: Windows",
3132
"Operating System :: MacOS",

src/nwbinspector/checks/_image_series.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
"""Check functions specific to ImageSeries."""
22

3-
import ntpath
4-
from pathlib import Path
3+
from pathlib import Path, PurePosixPath, PureWindowsPath
54
from typing import Iterable, Optional
65

76
from pynwb.image import ImageSeries
@@ -45,7 +44,7 @@ def check_image_series_external_file_relative(image_series: ImageSeries) -> Opti
4544
return None
4645
for file_path in image_series.external_file:
4746
file_path = file_path.decode() if isinstance(file_path, bytes) else file_path
48-
if ntpath.isabs(file_path): # ntpath required for cross-platform detection
47+
if PureWindowsPath(file_path).is_absolute() or PurePosixPath(file_path).is_absolute():
4948
yield InspectorMessage(
5049
message=(
5150
f"The external file '{file_path}' is not a relative path. "

0 commit comments

Comments
 (0)